Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard Freeze Update #4

2021-12-07 Thread Sami Mujawar
e block up into multiple > > > >> blocks by adding a carriage return. > > > >> > > > >>> For the benefit of others, this file can be a useful refernce > > > >>> understanding spans, gaps, and thresholds. > >

Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard Freeze Update #4

2021-12-06 Thread Chiu, Chasel
o; > maciej.rab...@linux.intel.com; Michael Kubacki > ; Andrew Fish (af...@apple.com) > ; Leif Lindholm ; Kinney, Michael D > > Subject: Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended > Hard Freeze Update #4 > > Hello EDK II Maintainers, > > A detai

Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard Freeze Update #4

2021-12-06 Thread Wang, Jian J
o; > maciej.rab...@linux.intel.com; Michael Kubacki > ; Andrew Fish (af...@apple.com) > ; Leif Lindholm ; Kinney, Michael D > > Subject: Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended > Hard Freeze Update #4 > > Hello EDK II Maintainers, > > A detailed ev

Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard Freeze Update #4

2021-12-06 Thread Abner Chang
6, 2021 9:18 AM > To: Michael Kubacki ; > devel@edk2.groups.io; maciej.rab...@linux.intel.com; Michael Kubacki > ; Andrew Fish (af...@apple.com) > ; Leif Lindholm ; Kinney, Michael D > > Subject: Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended > Hard F

Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard Freeze Update #4

2021-12-06 Thread Maciej Rabeda
To: Michael Kubacki ; devel@edk2.groups.io; maciej.rab...@linux.intel.com; Michael Kubacki ; Andrew Fish (af...@apple.com) ; Leif Lindholm ; Kinney, Michael D Subject: RE: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard Freeze Update #4 Hello EDK II Maintainers, I have entered

回复: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard Freeze Update #4

2021-12-06 Thread gaoliming
..@linux.intel.com; Michael Kubacki > ; Andrew Fish (af...@apple.com) > ; Leif Lindholm ; Kinney, Michael D > > 主题: Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended > Hard Freeze Update #4 > > Hello EDK II Maintainers, > > A detailed evaluation

Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard Freeze Update #4

2021-12-05 Thread Ni, Ray
Mike, Thank you! I know it's a bit hard to get every code to meet human expectations using auto-tools. But it's the first time that edk2 code is more consistent than before. Reviewed-by: Ray Ni for: UefiCpuPkg PcAtChipsetPkg SourceLevelDebugPkg ShellPkg EmulatorPkg FatPkg UefiPayl

Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard Freeze Update #4

2021-12-05 Thread Wu, Hao A
m; Michael Kubacki > ; Andrew Fish (af...@apple.com) > ; Leif Lindholm ; Kinney, Michael D > > Subject: Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended > Hard Freeze Update #4 > > Hello EDK II Maintainers, > > A detailed evaluation of the DEBUG_CODE()

Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard Freeze Update #4

2021-12-05 Thread Michael D Kinney
..@linux.intel.com; Michael Kubacki > ; Andrew Fish (af...@apple.com) > ; Leif Lindholm ; > Kinney, Michael D > Subject: RE: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended > Hard Freeze Update #4 > > Hello EDK II Maintainers, > > I have entered BZ 3760 to ma

Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard Freeze Update #4

2021-12-03 Thread Michael D Kinney
Hi Gerd, > -Original Message- > From: Gerd Hoffmann > Sent: Friday, December 3, 2021 12:56 AM > To: devel@edk2.groups.io; Kinney, Michael D > Cc: Michael Kubacki ; Andrew Fish > (af...@apple.com) ; Leif Lindholm > > Subject: Re: [edk2-devel] Uncrustify Conv

Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard Freeze Update #4

2021-12-03 Thread Gerd Hoffmann
Hi, > > https://github.com/mdkinney/edk2/tree/Bug_3737_3739_ApplyUncrustifyChanges_V5 >git fetch origin >git checkout master >git rebase origin/master > 2) Make a backup copy of plugin UncrustifyCheck outside WORKSPACE. >(e.g. C:\Temp\Uncru

Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard Freeze Update #4

2021-12-02 Thread Michael D Kinney
; Andrew Fish (af...@apple.com) > ; Leif Lindholm ; > Kinney, Michael D > Subject: RE: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended > Hard Freeze Update #4 > > Michael, > > Yes. Please update the patch series that adds UncrustifyCheck wit

Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard Freeze Update #4

2021-12-02 Thread Michael D Kinney
el.com; Michael Kubacki > ; Andrew Fish (af...@apple.com) > ; Leif Lindholm > Subject: Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended > Hard Freeze Update #4 > > Hi Mike, > > Thank you for the detailed analysis and recommendations. > > I agree wi

Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard Freeze Update #4

2021-12-02 Thread Michael Kubacki
, Mike -Original Message- From: Michael Kubacki Sent: Thursday, December 2, 2021 1:57 PM To: devel@edk2.groups.io; Kinney, Michael D ; maciej.rab...@linux.intel.com; Michael Kubacki ; Andrew Fish (af...@apple.com) ; Leif Lindholm Subject: Re: [edk2-devel] Uncrustify Conversion Detailed P

Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard Freeze Update #4

2021-12-02 Thread Michael D Kinney
ber 2, 2021 4:15 PM > To: Michael Kubacki ; devel@edk2.groups.io; > maciej.rab...@linux.intel.com; Michael Kubacki > ; Andrew Fish (af...@apple.com) > ; Leif Lindholm ; > Kinney, Michael D > Subject: RE: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended > Hard Freez

Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard Freeze Update #4

2021-12-02 Thread Michael D Kinney
ney, Michael D ; > maciej.rab...@linux.intel.com; Michael Kubacki > ; Andrew Fish (af...@apple.com) > ; Leif Lindholm > Subject: Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended > Hard Freeze Update #4 > > My reply is inline. > > Regards

Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard Freeze Update #4

2021-12-02 Thread Michael Kubacki
io *On Behalf Of *Maciej Rabeda *Sent:* Thursday, December 2, 2021 10:27 AM *To:* devel@edk2.groups.io; Kinney, Michael D ; Michael Kubacki ; Andrew Fish (af...@apple.com) ; Leif Lindholm *Subject:* Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard Freeze Update #4 Hey Mik

Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard Freeze Update #4

2021-12-02 Thread Michael D Kinney
; From: Michael Kubacki > Sent: Thursday, December 2, 2021 9:15 AM > To: Gerd Hoffmann > Cc: devel@edk2.groups.io; Kinney, Michael D ; > Chang, Abner ; Wang, Jian J > ; Michael Kubacki ; > Andrew Fish (af...@apple.com) ; > Leif Lindholm > Subject: Re: [edk2-devel] Uncrustif

Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard Freeze Update #4

2021-12-02 Thread Michael Kubacki
Thank you for clarifying. This case is more reasonable to me since the files are auto generated and not ported into edk2. There is an option to bring files like this in as a new submodule but I understand why that might not be desirable and would be disruptive to the current process. If ther

Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard Freeze Update #4

2021-12-02 Thread Gerd Hoffmann
On Thu, Dec 02, 2021 at 10:33:14AM -0500, Michael Kubacki wrote: > Hi Gerd, > > To help me understand which files you're specifically referring to, can you > please point them out from this commit? Or provide additional details? > > https://github.com/tianocore/edk2/pull/2229/commits/50654dfe5785

Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard Freeze Update #4

2021-12-02 Thread Michael Kubacki
Hi Gerd, To help me understand which files you're specifically referring to, can you please point them out from this commit? Or provide additional details? https://github.com/tianocore/edk2/pull/2229/commits/50654dfe5785964c9ae72961d13a50b26af77794 CryptoPkg/Library/Include/openssl/opensslcon

Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard Freeze Update #4

2021-12-02 Thread Gerd Hoffmann
On Wed, Dec 01, 2021 at 12:05:24PM -0500, Michael Kubacki wrote: > This can of course be done at a technical level but it smells of a code > cohesion problem. > > The code is in the edk2 project so it would reason that it should be uniform > in style with other code and at least close to the EDK I

Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard Freeze Update #4

2021-12-01 Thread Abner Chang
Fish (af...@apple.com) > ; Leif Lindholm ; Kinney, Michael D > > Subject: RE: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended > Hard Freeze Update #4 > > Hi Michael, > > This commit provides the background on why this content was copied into > edk2 > inst

Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard Freeze Update #4

2021-12-01 Thread Michael D Kinney
y, Michael D ; > Chang, Abner ; Wang, Jian J > ; Michael Kubacki ; > Andrew Fish (af...@apple.com) ; > Leif Lindholm > Subject: Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended > Hard Freeze Update #4 > > This can of course be done at a technical leve

Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard Freeze Update #4

2021-12-01 Thread Michael Kubacki
o; Wang, Jian J ; Kinney, Michael D ; Michael Kubacki ; Andrew Fish (af...@apple.com) ; Leif Lindholm Subject: Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard Freeze Update #4 Hi Mike, Is that possible to not applying uncrusitify on the source files that cloned from other o

Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard Freeze Update #4

2021-12-01 Thread Michael D Kinney
h (af...@apple.com) > ; Leif Lindholm > > Subject: Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended > Hard Freeze Update #4 > > Hi Mike, > Is that possible to not applying uncrusitify on the source files that cloned > from other open source? > e.g. Redfis

Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard Freeze Update #4

2021-12-01 Thread Sami Mujawar
Hi Mike, For DynamicTablesPkg, ArmPkg, ArmPlatformPkg, ArmVirtPkg & StandaloneMmPkg Reviewed-by: Sami Mujawar ( sami.muja...@arm.com ) Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#84202): https://edk2.groups.i

Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard Freeze Update #4

2021-11-30 Thread Abner Chang
> Wang, Jian J > Sent: Wednesday, December 1, 2021 2:39 PM > To: devel@edk2.groups.io; Kinney, Michael D ; > Michael Kubacki ; Andrew Fish > (af...@apple.com) ; Leif Lindholm > Subject: Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended > Hard Freeze Update

Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard Freeze Update #4

2021-11-30 Thread Wang, Jian J
> (af...@apple.com) ; Leif Lindholm > Subject: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard > Freeze Update #4 > > Hello, > > Thank you for your patience during this extended hard freeze. > > Just one more step to go. There has been a delay

Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard Freeze Update #4

2021-11-30 Thread Wang, Jian J
Andrew Fish > (af...@apple.com) ; Leif Lindholm > Subject: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard > Freeze Update #4 > > Hello, > > Thank you for your patience during this extended hard freeze. > > Just one more step to go. There has been a d

Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard Freeze Update #4

2021-11-30 Thread Chiu, Chasel
6:34 AM > To: devel@edk2.groups.io; Kinney, Michael D ; > Michael Kubacki ; Andrew Fish > (af...@apple.com) ; Leif Lindholm > Subject: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard > Freeze Update #4 > > Hello, > > Thank you for your patience during t

Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard Freeze Update #4

2021-11-30 Thread Ni, Ray
; Michael Kubacki ; Andrew Fish (af...@apple.com) ; Leif Lindholm Subject: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard Freeze Update #4 Hello, Thank you for your patience during this extended hard freeze. Just one more step to go. There has been a delay in the review of

回复: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard Freeze Update #4

2021-11-30 Thread gaoliming
dholm > 主题: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard > Freeze Update #4 > > Hello, > > Thank you for your patience during this extended hard freeze. > > Just one more step to go. There has been a delay in the review of > the patch series with t

Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard Freeze Update #4

2021-11-30 Thread Wu, Hao A
l] Uncrustify Conversion Detailed Plan and Extended > Hard Freeze Update #4 > > Hello, > > Thank you for your patience during this extended hard freeze. > > Just one more step to go. There has been a delay in the review of the patch > series with the uncrustify source ch

[edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard Freeze Update #4

2021-11-30 Thread Michael D Kinney
Hello, Thank you for your patience during this extended hard freeze. Just one more step to go. There has been a delay in the review of the patch series with the uncrustify source changes. PR(6). This patch series was not sent out as patch review email because of its very large size. It only