Thank you for clarifying. This case is more reasonable to me since the
files are auto generated and not ported into edk2.
There is an option to bring files like this in as a new submodule but I
understand why that might not be desirable and would be disruptive to
the current process.
If there's no objection, I'll add an option to exclude paths within a
package in a v6 patch of the plugin and leave this to maintainer
discretion. I just ask that the spirit of consistent formatting be
considered when making these decisions.
Regards,
Michael
On 12/2/2021 11:23 AM, Gerd Hoffmann wrote:
On Thu, Dec 02, 2021 at 10:33:14AM -0500, Michael Kubacki wrote:
Hi Gerd,
To help me understand which files you're specifically referring to, can you
please point them out from this commit? Or provide additional details?
https://github.com/tianocore/edk2/pull/2229/commits/50654dfe5785964c9ae72961d13a50b26af77794
CryptoPkg/Library/Include/openssl/opensslconf.h is currently formatted.
Yes, that one, and there is another in CryptoPkg/Library/Include/crypto/
The switch to openssl 3.0 will add more of those files[1]
They are generated from openssl source code,
CryptoPkg/Library/OpensslLib/process_files.pl handles that.
I think the two reasonable options to deal with that are:
(1) exclude those files from formating, or
(2) call uncrustify in process_files.pl to reformat them
each time they are generated.
Given that these files will never be edited manually my personal
preference would be (1).
take care,
Gerd
[1] wip branch @ https://github.com/kraxel/edk2/commits/openssl3
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#84265): https://edk2.groups.io/g/devel/message/84265
Mute This Topic: https://groups.io/mt/87414953/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
