9, 2021 5:32 PM
> To: edk2-devel-groups-io ; mikub...@linux.microsoft.com
> Cc: Kinney, Michael D ; Michael Kubacki
> ; Leif Lindholm
>
> Subject: Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended
> Hard Freeze Update #5 - Completed - Hard Freeze
> Lifte
Michael,
I’m still researching how to install the dependent tools so I can follow the
instructions. Do the stuart_* commands come from the EDKII Tools PIP? I think
I can get NuGet from brew, but the 1st Google hits suggested installing Visual
Studio for Mac.
If I pip the EDKII tools and inst
Hi Andrew,
I just sent the patch: https://edk2.groups.io/g/devel/message/84476
There's a rendered version of the file on my wiki fork:
https://github.com/makubacki/tianocore.github.io/blob/add_uncrustify_instructions/EDK-II-Code-Formatting.md
Thanks,
Michael
On 12/7/2021 4:04 PM, Andrew Fish
> On Dec 7, 2021, at 12:35 PM, Michael Kubacki
> wrote:
>
> I will send a patch for the Tianocore Wiki shortly.
>
OK thanks. I can test on Linux and macOS.
Maybe I’ll try using VS Code as my editor now….
Thanks,
Andrew Fish
> Thanks,
> Michael
>
> On 12/7/2021 2:27 PM, Andrew Fish via g
I will send a patch for the Tianocore Wiki shortly.
Thanks,
Michael
On 12/7/2021 2:27 PM, Andrew Fish via groups.io wrote:
On Dec 7, 2021, at 11:22 AM, Michael D Kinney
wrote:
Hello,
Thank you to everyone for their patience and for everyone who helped with the
development
and review of
> On Dec 7, 2021, at 11:22 AM, Michael D Kinney
> wrote:
>
> Hello,
>
> Thank you to everyone for their patience and for everyone who helped with the
> development
> and review of this important update to the edk2 repository.
>
> The last 2 PR series have completed review, passed EDK II CI
Hello,
Thank you to everyone for their patience and for everyone who helped with the
development
and review of this important update to the edk2 repository.
The last 2 PR series have completed review, passed EDK II CI checks, passed
CompareBuild
verifications, and been pushed.
https://gith
ds UncrustifyCheck with
those changes.
> >
> > Thanks,
> >
> > Mike
> >
> > > -Original Message-
> > > From: Michael Kubacki
> > > Sent: Thursday, December 2, 2021 4:31 PM
> > > To: Kinney, Mi
o;
> maciej.rab...@linux.intel.com; Michael Kubacki
> ; Andrew Fish (af...@apple.com)
> ; Leif Lindholm ; Kinney, Michael D
>
> Subject: Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended
> Hard Freeze Update #4
>
> Hello EDK II Maintainers,
>
> A detai
o;
> maciej.rab...@linux.intel.com; Michael Kubacki
> ; Andrew Fish (af...@apple.com)
> ; Leif Lindholm ; Kinney, Michael D
>
> Subject: Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended
> Hard Freeze Update #4
>
> Hello EDK II Maintainers,
>
> A detailed ev
6, 2021 9:18 AM
> To: Michael Kubacki ;
> devel@edk2.groups.io; maciej.rab...@linux.intel.com; Michael Kubacki
> ; Andrew Fish (af...@apple.com)
> ; Leif Lindholm ; Kinney, Michael D
>
> Subject: Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended
> Hard F
To: Michael Kubacki ; devel@edk2.groups.io;
maciej.rab...@linux.intel.com; Michael Kubacki
; Andrew Fish (af...@apple.com) ;
Leif Lindholm ;
Kinney, Michael D
Subject: RE: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard
Freeze Update #4
Hello EDK II Maintainers,
I have entered
..@linux.intel.com; Michael Kubacki
> ; Andrew Fish (af...@apple.com)
> ; Leif Lindholm ; Kinney, Michael D
>
> 主题: Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended
> Hard Freeze Update #4
>
> Hello EDK II Maintainers,
>
> A detailed evaluation
Mike,
Thank you! I know it's a bit hard to get every code to meet human expectations
using auto-tools.
But it's the first time that edk2 code is more consistent than before.
Reviewed-by: Ray Ni
for:
UefiCpuPkg
PcAtChipsetPkg
SourceLevelDebugPkg
ShellPkg
EmulatorPkg
FatPkg
UefiPayl
m; Michael Kubacki
> ; Andrew Fish (af...@apple.com)
> ; Leif Lindholm ; Kinney, Michael D
>
> Subject: Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended
> Hard Freeze Update #4
>
> Hello EDK II Maintainers,
>
> A detailed evaluation of the DEBUG_CODE()
..@linux.intel.com; Michael Kubacki
> ; Andrew Fish (af...@apple.com)
> ; Leif Lindholm ;
> Kinney, Michael D
> Subject: RE: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended
> Hard Freeze Update #4
>
> Hello EDK II Maintainers,
>
> I have entered BZ 3760 to ma
Hi Gerd,
> -Original Message-
> From: Gerd Hoffmann
> Sent: Friday, December 3, 2021 12:56 AM
> To: devel@edk2.groups.io; Kinney, Michael D
> Cc: Michael Kubacki ; Andrew Fish
> (af...@apple.com) ; Leif Lindholm
>
> Subject: Re: [edk2-devel] Uncrustify Conv
Hi,
>
> https://github.com/mdkinney/edk2/tree/Bug_3737_3739_ApplyUncrustifyChanges_V5
>git fetch origin
>git checkout master
>git rebase origin/master
> 2) Make a backup copy of plugin UncrustifyCheck outside WORKSPACE.
>(e.g. C:\Temp\Uncru
; Andrew Fish (af...@apple.com)
> ; Leif Lindholm ;
> Kinney, Michael D
> Subject: RE: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended
> Hard Freeze Update #4
>
> Michael,
>
> Yes. Please update the patch series that adds UncrustifyCheck wit
el.com; Michael Kubacki
> ; Andrew Fish (af...@apple.com)
> ; Leif Lindholm
> Subject: Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended
> Hard Freeze Update #4
>
> Hi Mike,
>
> Thank you for the detailed analysis and recommendations.
>
> I agree wi
,
Mike
-Original Message-
From: Michael Kubacki
Sent: Thursday, December 2, 2021 1:57 PM
To: devel@edk2.groups.io; Kinney, Michael D ;
maciej.rab...@linux.intel.com; Michael Kubacki
; Andrew Fish (af...@apple.com) ;
Leif Lindholm
Subject: Re: [edk2-devel] Uncrustify Conversion Detailed P
ber 2, 2021 4:15 PM
> To: Michael Kubacki ; devel@edk2.groups.io;
> maciej.rab...@linux.intel.com; Michael Kubacki
> ; Andrew Fish (af...@apple.com)
> ; Leif Lindholm ;
> Kinney, Michael D
> Subject: RE: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended
> Hard Freez
ney, Michael D ;
> maciej.rab...@linux.intel.com; Michael Kubacki
> ; Andrew Fish (af...@apple.com)
> ; Leif Lindholm
> Subject: Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended
> Hard Freeze Update #4
>
> My reply is inline.
>
> Regards
io *On Behalf Of *Maciej
Rabeda
*Sent:* Thursday, December 2, 2021 10:27 AM
*To:* devel@edk2.groups.io; Kinney, Michael D
; Michael Kubacki
; Andrew Fish (af...@apple.com)
; Leif Lindholm
*Subject:* Re: [edk2-devel] Uncrustify Conversion Detailed Plan and
Extended Hard Freeze Update #4
Hey Mik
; From: Michael Kubacki
> Sent: Thursday, December 2, 2021 9:15 AM
> To: Gerd Hoffmann
> Cc: devel@edk2.groups.io; Kinney, Michael D ;
> Chang, Abner ; Wang, Jian J
> ; Michael Kubacki ;
> Andrew Fish (af...@apple.com) ;
> Leif Lindholm
> Subject: Re: [edk2-devel] Uncrustif
Thank you for clarifying. This case is more reasonable to me since the
files are auto generated and not ported into edk2.
There is an option to bring files like this in as a new submodule but I
understand why that might not be desirable and would be disruptive to
the current process.
If ther
On Thu, Dec 02, 2021 at 10:33:14AM -0500, Michael Kubacki wrote:
> Hi Gerd,
>
> To help me understand which files you're specifically referring to, can you
> please point them out from this commit? Or provide additional details?
>
> https://github.com/tianocore/edk2/pull/2229/commits/50654dfe5785
Hi Gerd,
To help me understand which files you're specifically referring to, can
you please point them out from this commit? Or provide additional details?
https://github.com/tianocore/edk2/pull/2229/commits/50654dfe5785964c9ae72961d13a50b26af77794
CryptoPkg/Library/Include/openssl/opensslcon
On Wed, Dec 01, 2021 at 12:05:24PM -0500, Michael Kubacki wrote:
> This can of course be done at a technical level but it smells of a code
> cohesion problem.
>
> The code is in the edk2 project so it would reason that it should be uniform
> in style with other code and at least close to the EDK I
Fish (af...@apple.com)
> ; Leif Lindholm ; Kinney, Michael D
>
> Subject: RE: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended
> Hard Freeze Update #4
>
> Hi Michael,
>
> This commit provides the background on why this content was copied into
> edk2
> inst
y, Michael D ;
> Chang, Abner ; Wang, Jian J
> ; Michael Kubacki ;
> Andrew Fish (af...@apple.com) ;
> Leif Lindholm
> Subject: Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended
> Hard Freeze Update #4
>
> This can of course be done at a technical leve
o; Wang, Jian J ; Kinney, Michael D
; Michael
Kubacki ; Andrew Fish (af...@apple.com)
; Leif Lindholm
Subject: Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard
Freeze Update #4
Hi Mike,
Is that possible to not applying uncrusitify on the source files that cloned
from other o
h (af...@apple.com)
> ; Leif Lindholm
>
> Subject: Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended
> Hard Freeze Update #4
>
> Hi Mike,
> Is that possible to not applying uncrusitify on the source files that cloned
> from other open source?
> e.g. Redfis
Hi Mike,
For DynamicTablesPkg, ArmPkg, ArmPlatformPkg, ArmVirtPkg & StandaloneMmPkg
Reviewed-by: Sami Mujawar ( sami.muja...@arm.com )
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#84202): https://edk2.groups.i
> Wang, Jian J
> Sent: Wednesday, December 1, 2021 2:39 PM
> To: devel@edk2.groups.io; Kinney, Michael D ;
> Michael Kubacki ; Andrew Fish
> (af...@apple.com) ; Leif Lindholm
> Subject: Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended
> Hard Freeze Update
> (af...@apple.com) ; Leif Lindholm
> Subject: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard
> Freeze Update #4
>
> Hello,
>
> Thank you for your patience during this extended hard freeze.
>
> Just one more step to go. There has been a delay
Andrew Fish
> (af...@apple.com) ; Leif Lindholm
> Subject: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard
> Freeze Update #4
>
> Hello,
>
> Thank you for your patience during this extended hard freeze.
>
> Just one more step to go. There has been a d
6:34 AM
> To: devel@edk2.groups.io; Kinney, Michael D ;
> Michael Kubacki ; Andrew Fish
> (af...@apple.com) ; Leif Lindholm
> Subject: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard
> Freeze Update #4
>
> Hello,
>
> Thank you for your patience during t
;
Michael Kubacki ; Andrew Fish (af...@apple.com)
; Leif Lindholm
Subject: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard
Freeze Update #4
Hello,
Thank you for your patience during this extended hard freeze.
Just one more step to go. There has been a delay in the review of
dholm
> 主题: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard
> Freeze Update #4
>
> Hello,
>
> Thank you for your patience during this extended hard freeze.
>
> Just one more step to go. There has been a delay in the review of
> the patch series with t
l] Uncrustify Conversion Detailed Plan and Extended
> Hard Freeze Update #4
>
> Hello,
>
> Thank you for your patience during this extended hard freeze.
>
> Just one more step to go. There has been a delay in the review of the patch
> series with the uncrustify source ch
Hello,
Thank you for your patience during this extended hard freeze.
Just one more step to go. There has been a delay in the review of
the patch series with the uncrustify source changes. PR(6). This
patch series was not sent out as patch review email because of its
very large size. It only
Hello,
Changes from Update #2
* Changed order of PRs swapping (4) and (5). The PR that activates
increases the max CI agent job time is independent of all the other
PRs and its review is complete, so it can be commit
Hello,
Changes from Update #1
* Changed order of PRs swapping (6) and (7). The PR that activates
EDK II CI check UncrustifyCheck has to be last because it unconditionally
checks all C/H files in all packages. Not ju
Hello,
Michael Kubacki and I have prepared the patches required to apply the
uncrustify changes and enable EDK II CI to check all submitted
patches have been run through uncrustify.
We have verified through the CompareBuild GitHub Action that the
format changes performed by uncrustify have no fu
Hello,
Quick update on the CompareBuild failures with EmulatorPkg VS2019 IA32/X64.
It was pilot error running comparison against the incorrect git reference.
PR #1 (Update EmulatorPkg Win Host [BuildOptions] MSFT CC_FLAGS to not force
debug information)
is required for both runs to do the compar
Hello,
Michael Kubacki and I have prepared the patches required to apply the
uncrustify changes and enable EDK II CI to check all submitted
patches have been run through uncrustify.
There are a couple minor updates expected over the next day.
New versions of this email will be sent with the late
47 matches
Mail list logo
