Re: [edk2-devel] EFI table being corrupted during Kexec

2024-09-11 Thread Usama Arif
On 10/09/2024 15:26, Eric W. Biederman wrote: > Breno Leitao writes: > >> We've seen a problem in upstream kernel kexec, where a EFI TPM log event >> table >> is being overwritten. This problem happen on real machine, as well as in a >> recent EDK2 qemu VM. >> >> Digging deep, the table is b

Re: [edk2-devel] EFI table being corrupted during Kexec

2024-09-11 Thread Gerd Hoffmann
On Tue, Sep 10, 2024 at 08:44:40AM GMT, Andrew Fish via groups.io wrote: > > > > On Sep 10, 2024, at 6:58 AM, Breno Leitao wrote: > > > > > > We've seen a problem in upstream kernel kexec, where a EFI TPM log event > > table > > is being overwritten. This problem happen on real machine, as w

Re: [edk2-devel] EFI table being corrupted during Kexec

2024-09-10 Thread Gregory Price
On Tue, Sep 10, 2024 at 09:09:21AM -0700, Breno Leitao wrote: > hello Usama, > > On Tue, Sep 10, 2024 at 04:46:15PM +0100, Usama Arif wrote: > > --- a/drivers/firmware/efi/tpm.c > > +++ b/drivers/firmware/efi/tpm.c > > @@ -60,7 +60,9 @@ int __init efi_tpm_eventlog_init(void) > > } > > > >

Re: [edk2-devel] EFI table being corrupted during Kexec

2024-09-10 Thread Breno Leitao
hello Usama, On Tue, Sep 10, 2024 at 04:46:15PM +0100, Usama Arif wrote: > --- a/drivers/firmware/efi/tpm.c > +++ b/drivers/firmware/efi/tpm.c > @@ -60,7 +60,9 @@ int __init efi_tpm_eventlog_init(void) > } > > tbl_size = sizeof(*log_tbl) + log_tbl->size; > - memblock_reserve(efi.

Re: [edk2-devel] EFI table being corrupted during Kexec

2024-09-10 Thread Usama Arif
On 10/09/2024 15:26, Eric W. Biederman wrote: > Breno Leitao writes: > >> We've seen a problem in upstream kernel kexec, where a EFI TPM log event >> table >> is being overwritten. This problem happen on real machine, as well as in a >> recent EDK2 qemu VM. >> >> Digging deep, the table is b

Re: [edk2-devel] EFI table being corrupted during Kexec

2024-09-10 Thread Andrew Fish via groups.io
> On Sep 10, 2024, at 6:58 AM, Breno Leitao wrote: > > > We've seen a problem in upstream kernel kexec, where a EFI TPM log event table > is being overwritten. This problem happen on real machine, as well as in a > recent EDK2 qemu VM. > > Digging deep, the table is being overwritten during

[edk2-devel] EFI table being corrupted during Kexec

2024-09-10 Thread Breno Leitao
We've seen a problem in upstream kernel kexec, where a EFI TPM log event table is being overwritten. This problem happen on real machine, as well as in a recent EDK2 qemu VM. Digging deep, the table is being overwritten during kexec, more precisely when relocating kernel (relocate_kernel() func

Re: [edk2-devel] EFI table being corrupted during Kexec

2024-09-10 Thread Breno Leitao
Hello Eric, On Tue, Sep 10, 2024 at 09:26:00AM -0500, Eric W. Biederman wrote: > > I am wondering if that memory region/range should be part of e820 table > > that is > > passed by EFI firmware to kernel, and if it is not passed (as it is not > > being > > passed today), then the kernel doesn't