Re: [edk2-devel] [edk2-platforms: PATCH V5] Platform/Intel: Correct CPU APIC IDs

2021-08-05 Thread Ni, Ray
1. I see lots of coding style changes in the patch. Can you please separate these changes that don't impact functionality in a standalone patch? > +CpuIdMapPtr->AcpiProcessorId = > ((UINT32)ProcessorInfoBuffer.Location.Package * (UINT32)mNumberOfCpus * 2) + > Index; 2. Per ACPI spec, t

[edk2-devel] [edk2-platforms: PATCH V5] Platform/Intel: Correct CPU APIC IDs

2021-08-05 Thread JackX Lin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3365 BIOS cannot find correct AcpiProcId in mApicIdMap because of there is no suitable map, that causes ACPI_BIOS_ERROR. Remove mApicIdMap for determing AcpiProcId, uses normal countings instead. Signed-off-by: JackX Lin Cc: Chasel Chiu Cc: Je