1. I see lots of coding style changes in the patch. Can you please separate these changes that don't impact functionality in a standalone patch?
> + CpuIdMapPtr->AcpiProcessorId = > ((UINT32)ProcessorInfoBuffer.Location.Package * (UINT32)mNumberOfCpus * 2) + > Index; 2. Per ACPI spec, this value should match to the _UID value of processor object in ACPI table. What mechanism is used to guarantee the match? The original logic uses PCD value FixedPcdGet32(PcdMaxCpuCoreCount) * FixedPcdGet32(PcdMaxCpuThreadCount) to guarantee the match. We need to finalize the correct mechanism for the _UID match requirement in ACPI spec first. Then we can continue review the following reorder logic because the following logic depends on the initial order. Thanks, Ray -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#78775): https://edk2.groups.io/g/devel/message/78775 Mute This Topic: https://groups.io/mt/84680014/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
