Re: [edk2-devel] [edk2-discuss] Need memory barriers in IoLib for AARCH64

ple.com >> <mailto:af...@apple.com>; Wasim Khan >> mailto:wasim.k...@nxp.com>> >> Cc: Mike Kinney > <mailto:michael.d.kin...@intel.com>>; liming@intel.com >> <mailto:liming@intel.com>; Leif >> Lindholm (Nuvia address) mailto:

Re: [edk2-devel] [edk2-discuss] Need memory barriers in IoLib for AARCH64

> -Original Message- > From: Laszlo Ersek > Sent: Monday, July 13, 2020 9:02 PM > To: devel@edk2.groups.io; af...@apple.com; Wasim Khan > > Cc: Mike Kinney ; liming@intel.com; Leif > Lindholm (Nuvia address) > Subject: Re: [edk2-devel] [edk2-discuss] Need

Re: [edk2-devel] [edk2-discuss] Need memory barriers in IoLib for AARCH64

Wasim, Was there a specific function you had concerns about? Or was it confusion about the names? Hopefully the name confusion would have been fixed by 089e9c19a8c? Thanks, Andrew Fish > On Jul 13, 2020, at 8:31 AM, Laszlo Ersek wrote: > > On 07/12/20 18:54, Andrew Fish via groups.io

Re: [edk2-devel] [edk2-discuss] Need memory barriers in IoLib for AARCH64

On 07/12/20 18:54, Andrew Fish via groups.io wrote: > > >> On Jul 11, 2020, at 10:17 PM, Wasim Khan wrote: >> >> Hello >> >> Any comments ? >> > > I don’t see IoLibArm.c in master? I see IoLibNoIo.c. That's due to the rename in commit 089e9c19a8c1 ("MdePkg/BaseIoLibIntrinsic: Rename IoLibArm

Re: [edk2-devel] [edk2-discuss] Need memory barriers in IoLib for AARCH64

> On Jul 11, 2020, at 10:17 PM, Wasim Khan wrote: > > Hello > > Any comments ? > I don’t see IoLibArm.c in master? I see IoLibNoIo.c. The MMIO function look like ARM assembler with the correct barrier instructions. The IO operations in this lib are the x86 in/out instructions, so they j

Re: [edk2-devel] [edk2-discuss] Need memory barriers in IoLib for AARCH64

Hello Any comments ? > -Original Message- > From: Wasim Khan > Sent: Friday, July 10, 2020 6:20 PM > To: michael.d.kin...@intel.com; liming@intel.com; devel@edk2.groups.io > Subject: [edk2-discuss] Need memory barriers in IoLib for AARCH64 > > Hello, > > MdePkg/Library/BaseIoLibInt

[edk2-devel] [edk2-discuss] Need memory barriers in IoLib for AARCH64

Hello, MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf: IoLib library uses IoLibArm.c for AARCH64/ARM architecture and IoLib.c for other architectures. While IoLib.c already has memory barriers in MmioWrite functions, there barriers are missing in IoLibArm.c Is there any reason for **