Re: [edk2-devel] [PATCH v9 0/6] Simplify SMM Relocation Process

2023-03-12 Thread Wu, Jiaxin
ups.io; Ni, Ray ; Dong, Eric > ; Zeng, Star ; Laszlo Ersek > ; Kumar, Rahul R > Subject: RE: [edk2-devel] [PATCH v9 0/6] Simplify SMM Relocation Process > > I will have a try with the command. > > For BIOS shell trigger S3, it just needs a simple application to provide the

Re: [edk2-devel] [PATCH v9 0/6] Simplify SMM Relocation Process

2023-03-10 Thread Gerd Hoffmann
On Fri, Mar 10, 2023 at 10:29:30AM +, Wu, Jiaxin wrote: > Gerd, > > Could you help confirm whether this is regression in OVMF before I set up the > enviroment? What exactly? > > > > Run qemu command is: > > > > qemu-system-x86_64 -bios > > > C:\Dev\Code\edk2\Build\Ovmf3264\DEBUG_VS2015x86\F

Re: [edk2-devel] [PATCH v9 0/6] Simplify SMM Relocation Process

2023-03-10 Thread Wu, Jiaxin
eng, Star ; Laszlo Ersek > ; Kumar, Rahul R > Subject: RE: [edk2-devel] [PATCH v9 0/6] Simplify SMM Relocation Process > > I will have a try with the command. > > For BIOS shell trigger S3, it just needs a simple application to provide the > ACPI > FACS waking vecto

Re: [edk2-devel] [PATCH v9 0/6] Simplify SMM Relocation Process

2023-03-10 Thread Wu, Jiaxin
eng, Star ; Laszlo Ersek > ; Kumar, Rahul R > Subject: Re: [edk2-devel] [PATCH v9 0/6] Simplify SMM Relocation Process > > On Fri, Mar 10, 2023 at 09:19:04AM +, Wu, Jiaxin wrote: > > Is this regression? I remember I tried the S3 on real silicon with the patch > change, don&#

Re: [edk2-devel] [PATCH v9 0/6] Simplify SMM Relocation Process

2023-03-10 Thread Gerd Hoffmann
On Fri, Mar 10, 2023 at 09:19:04AM +, Wu, Jiaxin wrote: > Is this regression? I remember I tried the S3 on real silicon with the patch > change, don't see the issue in normal boot work flow. The only difference > what I did is to trigger S3 in the BIOS shell, but it does covered the > SmmRes

Re: [edk2-devel] [PATCH v9 0/6] Simplify SMM Relocation Process

2023-03-10 Thread Wu, Jiaxin
k > ; Kumar, Rahul R > Subject: Re: [edk2-devel] [PATCH v9 0/6] Simplify SMM Relocation Process > > On Mon, Mar 06, 2023 at 11:43:12AM +, Ni, Ray wrote: > > Gerd, > > Thanks for reporting. Can you kindly share the reproduce steps? > > (1) build OvmfPkgIa32X6

Re: [edk2-devel] [PATCH v9 0/6] Simplify SMM Relocation Process

2023-03-06 Thread Gerd Hoffmann
On Mon, Mar 06, 2023 at 11:43:12AM +, Ni, Ray wrote: > Gerd, > Thanks for reporting. Can you kindly share the reproduce steps? (1) build OvmfPkgIa32X64.dsc with SMM_REQUIRE=TRUE (2) boot linux guest using the firmware build. (3) suspend: use 'echo mem > /sys/power/state' on linux guest

Re: [edk2-devel] [PATCH v9 0/6] Simplify SMM Relocation Process

2023-03-06 Thread Ni, Ray
, Ray ; Wu, Jiaxin ; Dong, Eric > ; Zeng, Star ; Laszlo Ersek > ; Kumar, Rahul R > Subject: Re: [edk2-devel] [PATCH v9 0/6] Simplify SMM Relocation Process > > On Tue, Feb 21, 2023 at 09:48:54AM +0100, Gerd Hoffmann wrote: > > On Mon, Feb 20, 2023 at 01:14:33AM +, Ni,

Re: [edk2-devel] [PATCH v9 0/6] Simplify SMM Relocation Process

2023-03-06 Thread Gerd Hoffmann
On Tue, Feb 21, 2023 at 09:48:54AM +0100, Gerd Hoffmann wrote: > On Mon, Feb 20, 2023 at 01:14:33AM +, Ni, Ray wrote: > > I expect Gerd at least acknowledges all patches for UefiCpuPkg. Following > > three haven't got: > > * [PATCH v9 3/6] UefiCpuPkg/SmmBaseHob.h: Add SMM Base HOB Data > > *

Re: [edk2-devel] [PATCH v9 0/6] Simplify SMM Relocation Process

2023-02-21 Thread Gerd Hoffmann
On Tue, Feb 21, 2023 at 09:12:20AM +, Ni, Ray wrote: > Gerd, > I also don't think some Pentium processors still use the latest edk2 code. > Can you create a bugzilla for the request? > > If @Kinney, Michael D doesn't have concern, we can follow up on that old code > removal. https://bugzilla

Re: [edk2-devel] [PATCH v9 0/6] Simplify SMM Relocation Process

2023-02-21 Thread Ni, Ray
> Sent: Tuesday, February 21, 2023 4:49 PM > To: Ni, Ray > Cc: Wu, Jiaxin ; devel@edk2.groups.io; Dong, Eric > ; Zeng, Star ; Laszlo Ersek > ; Kumar, Rahul R > Subject: Re: [edk2-devel] [PATCH v9 0/6] Simplify SMM Relocation Process > > On Mon, Feb 20, 2023 at 01:14:33AM +0

Re: [edk2-devel] [PATCH v9 0/6] Simplify SMM Relocation Process

2023-02-21 Thread Gerd Hoffmann
On Mon, Feb 20, 2023 at 01:14:33AM +, Ni, Ray wrote: > I expect Gerd at least acknowledges all patches for UefiCpuPkg. Following > three haven't got: > * [PATCH v9 3/6] UefiCpuPkg/SmmBaseHob.h: Add SMM Base HOB Data > * [PATCH v9 4/6] UefiCpuPkg/PiSmmCpuDxeSmm: Consume SMM Base Hob for SmBas

Re: [edk2-devel] [PATCH v9 0/6] Simplify SMM Relocation Process

2023-02-19 Thread Ni, Ray
alf Of Wu, > Jiaxin > > Sent: Sunday, February 19, 2023 5:07 PM > > To: devel@edk2.groups.io; Wu, Jiaxin > > Cc: Dong, Eric ; Ni, Ray ; Zeng, > Star ; Laszlo Ersek > > ; Gerd Hoffmann ; Kumar, > Rahul R > > Subject: Re: [edk2-devel] [PATCH v9 0/6] Simpli

Re: [edk2-devel] [PATCH v9 0/6] Simplify SMM Relocation Process

2023-02-19 Thread Michael D Kinney
Ni, Ray ; Zeng, Star > ; Laszlo Ersek > ; Gerd Hoffmann ; Kumar, Rahul R > > Subject: Re: [edk2-devel] [PATCH v9 0/6] Simplify SMM Relocation Process > > Any more comments to patch series? If no objection, Ray, please help merge > the patches. > > Thanks, &

Re: [edk2-devel] [PATCH v9 0/6] Simplify SMM Relocation Process

2023-02-19 Thread Ni, Ray
Of Wu, > Jiaxin > > Sent: Thursday, February 16, 2023 2:16 PM > > To: devel@edk2.groups.io > > Cc: Dong, Eric ; Ni, Ray ; Zeng, > Star > > ; Laszlo Ersek ; Gerd > Hoffmann > > ; Kumar, Rahul R > > Subject: [edk2-devel] [PATCH v9 0/6] Simplify SMM Relocati

Re: [edk2-devel] [PATCH v9 0/6] Simplify SMM Relocation Process

2023-02-19 Thread Wu, Jiaxin
Ni, Ray ; Zeng, Star > ; Laszlo Ersek ; Gerd Hoffmann > ; Kumar, Rahul R > Subject: [edk2-devel] [PATCH v9 0/6] Simplify SMM Relocation Process > > Existing SMBASE Relocation is in the PiSmmCpuDxeSmm driver, which > will relocate the SMBASE of each processor by setting the SMBASE &

[edk2-devel] [PATCH v9 0/6] Simplify SMM Relocation Process

2023-02-15 Thread Wu, Jiaxin
Existing SMBASE Relocation is in the PiSmmCpuDxeSmm driver, which will relocate the SMBASE of each processor by setting the SMBASE field in the saved state map (at offset 7EF8h) to a new value. The RSM instruction reloads the internal SMBASE register with the value in SMBASE field when each time it