Re: [edk2-devel] [PATCH v7 00/43] SEV-ES guest support

2020-05-18 Thread Brian J. Johnson
njamin , Bi, Dandan , Dong, Guo , Wu, Hao A , Wang, Jian J , Ma, Maurice , Fan Jeff Subject: [edk2-devel] [PATCH v7 00/43] SEV-ES guest support On 5/15/20 12:47 AM, Ni, Ray wrote: I just realized my solution doesn't cover some scenarios: 1. SMM 2. S3 boot path 3. CapsuleX64 If we want to

Re: [edk2-devel] [PATCH v7 00/43] SEV-ES guest support

2020-05-15 Thread Lendacky, Thomas
; Ma, Maurice ; Fan Jeff Subject: Re: [edk2-devel] [PATCH v7 00/43] SEV-ES guest support On 5/14/20 8:10 AM, Ni, Ray wrote: Tom, Hi Ray, I just discussed with original CPU owner Jeff and went through how IDT is setup in the boot flow. Here is what I think you can do to avoid modifying the

Re: [edk2-devel] [PATCH v7 00/43] SEV-ES guest support

2020-05-14 Thread Ni, Ray
an ; Dong, Guo ; Wu, Hao A > ; Wang, Jian J > ; Ma, Maurice ; Fan Jeff > > Subject: Re: [edk2-devel] [PATCH v7 00/43] SEV-ES guest support > > On 5/14/20 8:10 AM, Ni, Ray wrote: > > Tom, > > Hi Ray, > > > I just discussed with original CPU owner Jeff and w

Re: [edk2-devel] [PATCH v7 00/43] SEV-ES guest support

2020-05-14 Thread Lendacky, Thomas
lo Ersek >> ; Ard Biesheuvel >> ; Kinney, Michael D ; >> Gao, Liming ; Dong, >> Eric ; Brijesh Singh ; You, >> Benjamin ; Bi, >> Dandan ; Dong, Guo ; Wu, Hao A >> ; Wang, Jian J >> ; Ma, Maurice >> Subject: Re: [edk2-devel] [PATCH v7 00/43] SEV

Re: [edk2-devel] [PATCH v7 00/43] SEV-ES guest support

2020-05-14 Thread Ni, Ray
af...@apple.com > Cc: Justen, Jordan L ; Laszlo Ersek > ; Ard Biesheuvel > ; Kinney, Michael D ; > Gao, Liming ; Dong, > Eric ; Brijesh Singh ; You, > Benjamin ; Bi, > Dandan ; Dong, Guo ; Wu, Hao A > ; Wang, Jian J > ; Ma, Maurice > Subject: Re: [edk2-devel] [PATC

Re: [edk2-devel] [PATCH v7 00/43] SEV-ES guest support

2020-05-12 Thread Lendacky, Thomas
On 5/12/20 12:44 PM, Tom Lendacky wrote: On 5/12/20 11:49 AM, Tom Lendacky wrote: On 5/9/20 2:09 PM, Andrew Fish wrote: On May 9, 2020, at 7:34 AM, Lendacky, Thomas > wrote: On 5/9/20 1:44 AM, Ni, Ray wrote: Tom, Hi Ray, I have a bit concern on your chang

Re: [edk2-devel] [PATCH v7 00/43] SEV-ES guest support

2020-05-12 Thread Lendacky, Thomas
On 5/12/20 11:49 AM, Tom Lendacky wrote: On 5/9/20 2:09 PM, Andrew Fish wrote: On May 9, 2020, at 7:34 AM, Lendacky, Thomas > wrote: On 5/9/20 1:44 AM, Ni, Ray wrote: Tom, Hi Ray, I have a bit concern on your change that directly modifies CpuExceptionHand

Re: [edk2-devel] [PATCH v7 00/43] SEV-ES guest support

2020-05-12 Thread Lendacky, Thomas
On 5/9/20 2:09 PM, Andrew Fish wrote: On May 9, 2020, at 7:34 AM, Lendacky, Thomas > wrote: On 5/9/20 1:44 AM, Ni, Ray wrote: Tom, Hi Ray, I have a bit concern on your change that directly modifies CpuExceptionHandlerLib to handle exception #29. Today's Cp

Re: [edk2-devel] [PATCH v7 00/43] SEV-ES guest support

2020-05-12 Thread Lendacky, Thomas
; Brijesh Singh ; You, Benjamin ; Bi, Dandan ; Dong, Guo ; Wu, Hao A ; Wang, Jian J ; Ma, Maurice *Subject:* Re: [edk2-devel] [PATCH v7 00/43] SEV-ES guest support On May 9, 2020, at 7:34 AM, Lendacky, Thomas mailto:thomas.lenda...@amd.com>> wrote: On 5/9/20 1:44 AM, Ni, Ray

Re: [edk2-devel] [PATCH v7 00/43] SEV-ES guest support

2020-05-11 Thread Laszlo Ersek
On 05/08/20 21:16, Tom Lendacky wrote: > I was able to use the pull request method that Laszlo documented and > fixed up all of the issues identified by the VS compiler. > > An additional change I'm planning to make for the next version (v8) of > the patches is to create a NULL library instance of

Re: [edk2-devel] [PATCH v7 00/43] SEV-ES guest support

2020-05-10 Thread Ni, Ray
, Ray ; Justen, Jordan L ; Laszlo Ersek ; Ard Biesheuvel ; Kinney, Michael D ; Gao, Liming ; Dong, Eric ; Brijesh Singh ; You, Benjamin ; Bi, Dandan ; Dong, Guo ; Wu, Hao A ; Wang, Jian J ; Ma, Maurice Subject: Re: [edk2-devel] [PATCH v7 00/43] SEV-ES guest support On May 9, 2020, at 7:

Re: [edk2-devel] [PATCH v7 00/43] SEV-ES guest support

2020-05-09 Thread Andrew Fish via groups.io
> On May 9, 2020, at 7:34 AM, Lendacky, Thomas wrote: > > On 5/9/20 1:44 AM, Ni, Ray wrote: >> Tom, > > Hi Ray, > >> I have a bit concern on your change that directly modifies >> CpuExceptionHandlerLib to handle >> exception #29. Today's CpuExceptionHandlerLib simplify dumps the exception >

Re: [edk2-devel] [PATCH v7 00/43] SEV-ES guest support

2020-05-09 Thread Lendacky, Thomas
On 5/9/20 1:44 AM, Ni, Ray wrote: Tom, Hi Ray, I have a bit concern on your change that directly modifies CpuExceptionHandlerLib to handle exception #29. Today's CpuExceptionHandlerLib simplify dumps the exception context for every exception. Any component which wants to do specific handlin

Re: [edk2-devel] [PATCH v7 00/43] SEV-ES guest support

2020-05-08 Thread Ni, Ray
Tom, I have a bit concern on your change that directly modifies CpuExceptionHandlerLib to handle exception #29. Today's CpuExceptionHandlerLib simplify dumps the exception context for every exception. Any component which wants to do specific handling of certain exceptions should call RegisterCpu

Re: [edk2-devel] [PATCH v7 00/43] SEV-ES guest support

2020-05-08 Thread Lendacky, Thomas
I was able to use the pull request method that Laszlo documented and fixed up all of the issues identified by the VS compiler. An additional change I'm planning to make for the next version (v8) of the patches is to create a NULL library instance of the VmgExitLib that will also include the #V

[edk2-devel] [PATCH v7 00/43] SEV-ES guest support

2020-04-22 Thread Lendacky, Thomas
This patch series provides support for running EDK2/OVMF under SEV-ES. Secure Encrypted Virtualization - Encrypted State (SEV-ES) expands on the SEV support to protect the guest register state from the hypervisor. See "AMD64 Architecture Programmer's Manual Volume 2: System Programming", section "