On 05/08/20 21:16, Tom Lendacky wrote:
> I was able to use the pull request method that Laszlo documented and
> fixed up all of the issues identified by the VS compiler.
>
> An additional change I'm planning to make for the next version (v8) of
> the patches is to create a NULL library instance of the VmgExitLib that
> will also include the #VC handler function. This will reduce the amount
> of code associated with this feature for platforms that don't
> use/support SEV-ES.
>
> Laszlo, this will mean that I will introduce a version of the VmgExitLib
> under OvmfPkg that will provide the majority of the functionality that
> is present today in UefiCpuPkg. In essence, the functionality in v7
> patches 8 and 11 - 25 will now live under OvmfPkg instead of UefiCpuPkg.
> I think this is the better way to do this. Let me know if you have any
> concerns.
That's OK with me.
I'll have to spend more time to review those patches, of course. I think
I'll go for Acked-by tags only, as these modules should be well-contained.
In the next version, please consider introducing a new section to the
"Maintainers.txt" file, and listing yourself and Brijesh in "R" roles
for the (new) VmgExitLib and CpuExceptionHandlerLib instances under OvmfPkg.
Best would be to list all the new files and modules introcuced by this
patch set under OvmfPkg -- maybe Eric and Ray would prefer that for
UefiCpuPkg as well. That's their call; for OvmfPkg I'd like this
additional reviewership spelled out.
Recent examples:
- 335644f90f15 ("Maintainers.txt: Add Liran and Nikita as
OvmfPkg/PvScsiDxe reviewers", 2020-04-01)
- feec20b28dd0 ("OvmfPkg/MptScsiDxe: Create empty driver", 2020-05-05)
Thanks!
Laszlo
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#59098): https://edk2.groups.io/g/devel/message/59098
Mute This Topic: https://groups.io/mt/73201885/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
