Hi Brijesh
I think it is OK to leave MpFunc.nasm in this series.
We can revisit later.
Thank you
Yao Jiewen
> -Original Message-
> From: Brijesh Singh
> Sent: Monday, September 13, 2021 6:56 AM
> To: Yao, Jiewen ; devel@edk2.groups.io
> Cc: James Bottomley ; Xu, Min M ;
> Tom Lendacky ;
Hi Yao,
I am going through implementing your feedback. I have covered most of
it. But your comment on moving some of the changes from MpFunc.nasm to
Sev.nasm may make code harder to read. It is mainly because the GPA
registration and Topo check are not self-contained routines. They depend
on some
rd Biesheuvel ; Erdem Aktas
> ; Michael Roth ; Gerd
> Hoffmann
> Subject: Re: [edk2-devel] [PATCH v6 00/29] Add AMD Secure Nested Paging
> (SEV-SNP) support
>
> Hi Min,
>
> On 9/8/21 7:31 PM, Xu, Min M wrote:
> > On September 9, 2021 3:46 AM, Brijesh Singh wrote:
> >&
On September 9, 2021 7:40 PM, Brijesh Singh wrote:
> On 9/9/21 6:22 AM, Gerd Hoffmann wrote:
> > Hi,
> >
> >> I am not sure if its a good idea to pack a header like above in a
> >> 32-bit PCD. The caller need to unpack the 32-bit number and perform a
> >> bitshit etc. Additionally we also need to
On 9/9/21 6:22 AM, Gerd Hoffmann wrote:
> Hi,
>
>> I am not sure if its a good idea to pack a header like above in a 32-bit
>> PCD. The caller need to unpack the 32-bit number and perform a bitshit
>> etc. Additionally we also need to check for reserved bits being set to
>> zero etc. I am more
Hi,
> I am not sure if its a good idea to pack a header like above in a 32-bit
> PCD. The caller need to unpack the 32-bit number and perform a bitshit
> etc. Additionally we also need to check for reserved bits being set to
> zero etc. I am more inclined toward something like this:
>
> enum {
Hi Min,
On 9/8/21 7:31 PM, Xu, Min M wrote:
> On September 9, 2021 3:46 AM, Brijesh Singh wrote:
>> Thank you so much Yao for reviewing the patches. Based on some comments
>> from Gerd I may update code around the reset vector area (mainly use the
>> metadata format etc). For your comments regardi
On September 9, 2021 3:46 AM, Brijesh Singh wrote:
>
> Thank you so much Yao for reviewing the patches. Based on some comments
> from Gerd I may update code around the reset vector area (mainly use the
> metadata format etc). For your comments regarding the introducing a new
> PcdConfidentialCompu
Thank you so much Yao for reviewing the patches. Based on some comments
from Gerd I may update code around the reset vector area (mainly use the
metadata format etc). For your comments regarding the introducing a new
PcdConfidentialComputingCategory I will look to see what I can come up
with an
Yes, that is good idea.
> -Original Message-
> From: Xu, Min M
> Sent: Wednesday, September 8, 2021 10:30 AM
> To: Yao, Jiewen ; Brijesh Singh
> ; devel@edk2.groups.io
> Cc: James Bottomley ; Tom Lendacky
> ; Justen, Jordan L ;
> Ard Biesheuvel ; Erdem Aktas
> ; Michael Roth ; Gerd
> Hoff
On September 7, 2021 10:37 AM, Jiewen Yao wrote:
>
> 0008-UefiCpuPkg-Define-the-SEV-SNP-specific-dynamic-PCDs
> I really don't like the idea to use BOOL PcdSevEsIsEnabled and
> PcdSevSnpIsEnabled.
> Can we define *one* PCD - such as PcdConfidentialComputingCategory?
> We can assign range 0x~0x
Thank you Brijesh
It took me a while to review this series. Here is my feedback.
I am not sure what you prefer, to put all comment together? Or reply 29 email
separately?
Let me put them together in this version. If you prefer a different way, please
let me know.
My strategy is same as previous.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275
SEV-SNP builds upon existing SEV and SEV-ES functionality while adding
new hardware-based memory protections. SEV-SNP adds strong memory integrity
protection to help prevent malicious hypervisor-based attacks like data
replay, memory re-mappi
13 matches
Mail list logo
