> -Original Message-
> From: Rabeda, Maciej
> Sent: Wednesday, August 19, 2020 10:44 AM
> To: Laszlo Ersek ; Vladimir Olovyannikov
> ; Gao, Zhichao
> ; devel@edk2.groups.io
> Cc: Samer El-Haj-Mahmoud ; Wu, Jiaxin
> ; Fu, Siyuan ; Ni, Ray
> ; Gao, Liming ; Nd
>
> Subject: Re: [PATCH v5 1/1
@Laszlo,
As for type casting, I don't have strong opinions.
Space after typecast (for me) always seemed to be visually more
consistent with the rest of the code.
In my regular projects written in C-based languages, I would do it the
way you are describing.
@Vladimir
I went through the rest of
On 08/18/20 20:33, Vladimir Olovyannikov wrote:
>> -Original Message-
>> From: Rabeda, Maciej
>> Sent: Tuesday, August 18, 2020 9:54 AM
>> To: Vladimir Olovyannikov ; Laszlo
>> Ersek ; Gao, Zhichao ;
>> devel@edk2.groups.io
>> Cc: Samer El-Haj-Mahmoud ; Wu, Jiaxin
>> ; Fu, Siyuan ; Ni, Ray
Hi Rabeda,
Thank you for reviewing.
> -Original Message-
> From: Rabeda, Maciej
> Sent: Tuesday, August 18, 2020 9:54 AM
> To: Vladimir Olovyannikov ; Laszlo
> Ersek ; Gao, Zhichao ;
> devel@edk2.groups.io
> Cc: Samer El-Haj-Mahmoud ; Wu, Jiaxin
> ; Fu, Siyuan ; Ni, Ray
> ; Gao, Liming ;
Hi Vladimir,
I am inprog of going through the patch. There are some coding standard
violations.
For reference:
https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specification/
Http.c:
Lines 110-111: Spacing before open bracket and != operator
Line 133: Unnecessary brackets around EFI_SUC
> -Original Message-
> From: Laszlo Ersek
> Sent: Monday, August 17, 2020 1:44 PM
> To: Vladimir Olovyannikov ;
> Rabeda, Maciej ; Gao, Zhichao
> ; devel@edk2.groups.io
> Cc: Samer El-Haj-Mahmoud ; Wu, Jiaxin
> ; Fu, Siyuan ; Ni, Ray
> ; Gao, Liming ; Nd
>
> Subject: Re: [PATCH v5 1/1] Sh
On 08/17/20 20:29, Vladimir Olovyannikov wrote:
>> -Original Message-
>> From: Laszlo Ersek
>> Sent: Monday, August 17, 2020 11:01 AM
>> To: Rabeda, Maciej ; Vladimir Olovyannikov
>> ; Gao, Zhichao
>> ; devel@edk2.groups.io
>> Cc: Samer El-Haj-Mahmoud ; Wu, Jiaxin
>> ; Fu, Siyuan ; Ni, Ray
> -Original Message-
> From: Laszlo Ersek
> Sent: Monday, August 17, 2020 11:01 AM
> To: Rabeda, Maciej ; Vladimir Olovyannikov
> ; Gao, Zhichao
> ; devel@edk2.groups.io
> Cc: Samer El-Haj-Mahmoud ; Wu, Jiaxin
> ; Fu, Siyuan ; Ni, Ray
> ; Gao, Liming ; Nd
>
> Subject: Re: [PATCH v5 1/1] S
On 08/17/20 19:15, Rabeda, Maciej wrote:
> Hi Vladimir,
>
> I cannot apply the patch via 'git am'.
> Is your git configured in a manner described here?
> https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers
>
>
> Laszlo,
>
> Were
Hi Vladimir,
I cannot apply the patch via 'git am'.
Is your git configured in a manner described here?
https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers
Laszlo,
Were you able to apply this patch from .eml file?
Thanks,
Maciej
Hi Gao,
Thanks for reviewing.
As you suggest, I will postpone the next patchset submission until
NetworkPkg maintainer(s) review.
> -Original Message-
> From: Gao, Zhichao
> Sent: Sunday, August 16, 2020 6:48 PM
> To: Vladimir Olovyannikov ;
> devel@edk2.groups.io
> Cc: Laszlo Ersek ; Sa
Sorry for the delay reply.
See below:
> -Original Message-
> From: Vladimir Olovyannikov
> Sent: Tuesday, July 28, 2020 12:49 AM
> To: devel@edk2.groups.io
> Cc: Laszlo Ersek ; Vladimir Olovyannikov
> ; Samer El-Haj-Mahmoud haj-mahm...@arm.com>; Gao, Zhichao ; Maciej
> Rabeda ; Wu, Jiax
> To: devel@edk2.groups.io; vladimir.olovyanni...@broadcom.com
> Cc: Samer El-Haj-Mahmoud ; Zhichao
> Gao ; Maciej Rabeda
> ; Jiaxin Wu ; Siyuan
> Fu ; Ray Ni ; Liming Gao
> ; Nd
> Subject: Re: [edk2-devel] [PATCH v5 1/1] ShellPkg/DynamicCommand: add
> HttpDynamicCommand
Maciej, Jiaxin and Siyuan:
As you are network exporters, could you give the comments for this change?
Thanks
Liming
-Original Message-
From: Vladimir Olovyannikov
Sent: 2020年7月28日 0:49
To: devel@edk2.groups.io
Cc: Laszlo Ersek ; Vladimir Olovyannikov
; Samer El-Haj-Mahmoud
; Gao, Zhi
Just some quick remarks after a comparison with v3:
On 07/27/20 18:48, Vladimir Olovyannikov via groups.io wrote:
> Introduce an http client utilizing EDK2 HTTP protocol, to
> allow fast image downloading from http/https servers.
> HTTP download speed is usually faster than tftp.
> The client is b
Introduce an http client utilizing EDK2 HTTP protocol, to
allow fast image downloading from http/https servers.
HTTP download speed is usually faster than tftp.
The client is based on the same approach as tftp dynamic command, and
uses the same UEFI Shell command line parameters. This makes it easy
16 matches
Mail list logo
