> -----Original Message-----
> From: Laszlo Ersek <ler...@redhat.com>
> Sent: Monday, August 17, 2020 1:44 PM
> To: Vladimir Olovyannikov <vladimir.olovyanni...@broadcom.com>;
> Rabeda, Maciej <maciej.rab...@linux.intel.com>; Gao, Zhichao
> <zhichao....@intel.com>; devel@edk2.groups.io
> Cc: Samer El-Haj-Mahmoud <samer.el-haj-mahm...@arm.com>; Wu, Jiaxin
> <jiaxin...@intel.com>; Fu, Siyuan <siyuan...@intel.com>; Ni, Ray
> <ray...@intel.com>; Gao, Liming <liming....@intel.com>; Nd
> <n...@arm.com>
> Subject: Re: [PATCH v5 1/1] ShellPkg/DynamicCommand: add
> HttpDynamicCommand
>
> On 08/17/20 20:29, Vladimir Olovyannikov wrote:
> >> -----Original Message-----
> >> From: Laszlo Ersek <ler...@redhat.com>
> >> Sent: Monday, August 17, 2020 11:01 AM
> >> To: Rabeda, Maciej <maciej.rab...@linux.intel.com>; Vladimir
> >> Olovyannikov <vladimir.olovyanni...@broadcom.com>; Gao, Zhichao
> >> <zhichao....@intel.com>; devel@edk2.groups.io
> >> Cc: Samer El-Haj-Mahmoud <samer.el-haj-mahm...@arm.com>; Wu,
> Jiaxin
> >> <jiaxin...@intel.com>; Fu, Siyuan <siyuan...@intel.com>; Ni, Ray
> >> <ray...@intel.com>; Gao, Liming <liming....@intel.com>; Nd
> >> <n...@arm.com>
> >> Subject: Re: [PATCH v5 1/1] ShellPkg/DynamicCommand: add
> >> HttpDynamicCommand
> >>
> >> On 08/17/20 19:15, Rabeda, Maciej wrote:
> >>> Hi Vladimir,
> >>>
> >>> I cannot apply the patch via 'git am'.
> >>> Is your git configured in a manner described here?
> >>> https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkem
> >>> pt -git-guide-for-edk2-contributors-and-maintainers
> > Hi Rabeda,
> > Yes, I followed the page. I did not run the SetupGit.py though.
> >>>
> >>>
> >>> Laszlo,
> >>>
> >>> Were you able to apply this patch from .eml file?
> >>
> >> Yes, but I had to use some tricks (implemented by my colleague Paolo
> >> in a python script) to undo the damage caused by the "quoted-printable"
> >> content-transfer-encoding on the posting.
> >>
> >> Our recommended Content-Transfer-Encoding (that is,
> >> "sendemail.transferEncoding") is "8bit", or even "base64".
> >> quoted-printable is practically impossible to get functional, with
> >> the hard CRLF line endings in edk2.
> >>
> >> "BaseTools/Scripts/SetupGit.py" does set "8bit".
> > Thank you for notice Laszlo,
> > So, should I run this script and re-send the patch as v6?
>
> I think that would be useful, yes -- and if you have made no changes since
> v5,
> you can also post it as "v5 RESEND". If you've implemented some changes
> meanwhile, then please post it as v6 indeed.
Thanks Laszlo,
I will post v6.

Vladimir
>
> Thanks
> Laszlo

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#64337): https://edk2.groups.io/g/devel/message/64337
Mute This Topic: https://groups.io/mt/75826968/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to