Re: [edk2-devel] [PATCH v5 0/3] DynamicTablesPkg: _CPC support

2022-09-23 Thread Sami Mujawar
Merged as 953438e4665c..2500ce101178 Thanks. Regards, Sami Mujawar On 23/09/2022 06:05 pm, Jeff Brasen wrote: Those changes look good to me. Thanks, Jeff -Original Message- From: Sami Mujawar Sent: Friday, September 23, 2022 10:55 AM To: Jeff Brasen ; devel@edk2.groups.io Cc: ardb

Re: [edk2-devel] [PATCH v5 0/3] DynamicTablesPkg: _CPC support

2022-09-23 Thread Jeff Brasen via groups.io
Those changes look good to me. Thanks, Jeff > -Original Message- > From: Sami Mujawar > Sent: Friday, September 23, 2022 10:55 AM > To: Jeff Brasen ; devel@edk2.groups.io > Cc: ardb+tianoc...@kernel.org; alexei.fedo...@arm.com; > pierre.gond...@arm.com; n...@arm.com > Subject: Re: [PATCH

Re: [edk2-devel] [PATCH v5 0/3] DynamicTablesPkg: _CPC support

2022-09-23 Thread Sami Mujawar
Hi Jeff, Thank you for the updated patch series. I have made some minor changes: 1. Move DynamicTablesPkg/Include/Library/AmlCpcInfo.h to DynamicTablesPkg/Include/AmlCpcInfo.h to stop edk2 CI from complaining. 2. Minor update to the documentation for CpcToken in CM_ARM_GICC_INFO. I have sch

[edk2-devel] [PATCH v5 0/3] DynamicTablesPkg: _CPC support

2022-09-22 Thread Jeff Brasen via groups.io
Add generator for creating the _CPC object for CPU nodes. If viewing this review by a pull request is helpful one exists here: https://github.com/NVIDIA/edk2/pull/12 Change Log: v1 - Initial Revision v2 - Added revision to object, improved error handling, changed to ACPI 6.4 structures. v3 - Min