Hi Jeff,
Thank you for the updated patch series.
I have made some minor changes:
1. Move DynamicTablesPkg/Include/Library/AmlCpcInfo.h to
DynamicTablesPkg/Include/AmlCpcInfo.h to stop edk2 CI from complaining.
2. Minor update to the documentation for CpcToken in CM_ARM_GICC_INFO.
I have scheduled a pull request
(https://github.com/samimujawar/edk2/pull/new/REVIEW_2369_dynamic_cpc_support_v5)
for checking that edk2 CI is happy with the changes.
Please let me know if you are ok with the above changes, and I will push
these changes.
For this series:
Reviewed-by: Sami Mujawar <sami.muja...@arm.com>
Regards,
Sami Mujawar
On 22/09/2022 09:36 pm, Jeff Brasen wrote:
Add generator for creating the _CPC object for CPU nodes.
If viewing this review by a pull request is helpful one exists here:
https://github.com/NVIDIA/edk2/pull/12
Change Log:
v1 - Initial Revision
v2 - Added revision to object, improved error handling, changed to ACPI 6.4
structures.
v3 - Minor review feedback
v4 - Convert CpcInfo to structure and use that for APIs
v5 - Cleanup parameter checks, add token to parser
Jeff Brasen (3):
DynamicTablesPkg: Add CM_ARM_CPC_INFO object
DynamicTablesPkg: AML Code generation to add _CPC entries
DynamicTablesPkg: SSDT CPU _CPC generator
.../Include/ArmNameSpaceObjects.h | 60 ++-
DynamicTablesPkg/Include/Library/AmlCpcInfo.h | 124 +++++
.../Include/Library/AmlLib/AmlLib.h | 54 ++
.../SsdtCpuTopologyGenerator.c | 133 ++++-
.../Common/AmlLib/CodeGen/AmlCodeGen.c | 475 ++++++++++++++++++
.../ConfigurationManagerObjectParser.c | 115 ++++-
6 files changed, 921 insertions(+), 40 deletions(-)
create mode 100644 DynamicTablesPkg/Include/Library/AmlCpcInfo.h
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#94240): https://edk2.groups.io/g/devel/message/94240
Mute This Topic: https://groups.io/mt/93857387/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
