Re: [edk2-devel] [PATCH v4 0/2] Set Firmware Version from build command line

2023-05-04 Thread Ard Biesheuvel
On Thu, 4 May 2023 at 12:13, Gerd Hoffmann wrote: > > Ping. > I'll pick these up - thanks for the reminder. > On Fri, Apr 14, 2023 at 10:33:21AM +0200, Oliver Steffen wrote: > > ArmVirtXen.dsc allows setting the firmware version > > string in gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionStr

Re: [edk2-devel] [PATCH v4 0/2] Set Firmware Version from build command line

2023-05-04 Thread Gerd Hoffmann
Ping. On Fri, Apr 14, 2023 at 10:33:21AM +0200, Oliver Steffen wrote: > ArmVirtXen.dsc allows setting the firmware version > string in gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString > via FIRMWARE_VER variable conveniently on the build command line. > > These two patches add this behavio

Re: [edk2-devel] [PATCH v4 0/2] Set Firmware Version from build command line

2023-04-17 Thread Rebecca Cran
On 4/17/23 4:17 AM, Gerd Hoffmann wrote: On Fri, Apr 14, 2023 at 06:13:03AM -0600, Rebecca Cran wrote: Sorry for not commenting on this earlier. Would it be better to have people use the build `--pcd` option instead? e.g. build --pcd="gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString=edk

Re: [edk2-devel] [PATCH v4 0/2] Set Firmware Version from build command line

2023-04-17 Thread Gerd Hoffmann
On Fri, Apr 14, 2023 at 06:13:03AM -0600, Rebecca Cran wrote: > Sorry for not commenting on this earlier. > > Would it be better to have people use the build `--pcd` option instead? e.g. > build > --pcd="gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString=edk2-stable202302". Possible, but th

Re: [edk2-devel] [PATCH v4 0/2] Set Firmware Version from build command line

2023-04-14 Thread Rebecca Cran
Sorry for not commenting on this earlier. Would it be better to have people use the build `--pcd` option instead? e.g. build --pcd="gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString=edk2-stable202302". -- Rebecca Cran On 4/14/23 02:33, Oliver Steffen wrote: ArmVirtXen.dsc allows se

[edk2-devel] [PATCH v4 0/2] Set Firmware Version from build command line

2023-04-14 Thread Oliver Steffen
ArmVirtXen.dsc allows setting the firmware version string in gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString via FIRMWARE_VER variable conveniently on the build command line. These two patches add this behavior to all .dsc files in ArmVirtPkg and OvmfPkg. PR: https://github.com/tianocore/