Re: [edk2-devel] [PATCH v3 1/1] Platform/SbsaQemu: read platform version

2023-05-10 Thread Marcin Juszkiewicz
W dniu 10.05.2023 o 18:14, Rebecca Cran pisze: Sorry, but there are new problems. No problem. Thanks for reviewing. There should be a space before the parenthesis in the 'DEBUG' line. No problem. I hope that one day someone will run source formatter on whole edk2-platforms so it would be

Re: [edk2-devel] [PATCH v3 1/1] Platform/SbsaQemu: read platform version

2023-05-10 Thread Rebecca Cran
On 5/10/23 10:06, Marcin Juszkiewicz wrote: + Result = ArmCallSmc0 (SIP_SVC_VERSION, &Major, &Minor, NULL); + if (Result == SMC_ARCH_CALL_SUCCESS) + { +Result = PcdSet32S (PcdPlatformVersionMajor, Major); +ASSERT_EFI_ERROR (Result); +Result = PcdSet32S (PcdPlatformVersi

[edk2-devel] [PATCH v3 1/1] Platform/SbsaQemu: read platform version

2023-05-10 Thread Marcin Juszkiewicz
Qemu has versioning for sbsa-ref platform. TF-A reads it from provided DeviceTree and provides as SMC. This change adds reading platform version into EDK2. Signed-off-by: Marcin Juszkiewicz --- Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 3 ++ .../SbsaQemuPlatformDxe/SbsaQemuPlatformDxe.c