Re: [edk2-devel] [PATCH v2 21/28] Slicon/NXP: Add PlatformPei Lib

2020-04-08 Thread Leif Lindholm
On Tue, Apr 07, 2020 at 17:00:50 +, Pankaj Bansal wrote: > > OK, taking another look at this patch, this simply needs to be > > deleted. Here is the sum total relevant difference compared to the > > ArmPlatformPkg one. > > > > DEBUG ((DEBUG_INIT, "Edk2 version is %a\n", XPRINT > > (WORKSPACE

Re: [edk2-devel] [PATCH v2 21/28] Slicon/NXP: Add PlatformPei Lib

2020-04-07 Thread Pankaj Bansal
> OK, taking another look at this patch, this simply needs to be > deleted. Here is the sum total relevant difference compared to the > ArmPlatformPkg one. > > DEBUG ((DEBUG_INIT, "Edk2 version is %a\n", XPRINT > (WORKSPACE_GIT_VERSION))); > DEBUG ((DEBUG_INIT, "Edk2 platforms version is %a\n"

Re: [edk2-devel] [PATCH v2 21/28] Slicon/NXP: Add PlatformPei Lib

2020-04-07 Thread Leif Lindholm
OK, taking another look at this patch, this simply needs to be deleted. Here is the sum total relevant difference compared to the ArmPlatformPkg one. DEBUG ((DEBUG_INIT, "Edk2 version is %a\n", XPRINT (WORKSPACE_GIT_VERSION))); DEBUG ((DEBUG_INIT, "Edk2 platforms version is %a\n", XPRINT (PAC

Re: [edk2-devel] [PATCH v2 21/28] Slicon/NXP: Add PlatformPei Lib

2020-04-06 Thread Pankaj Bansal
> -Original Message- > From: Leif Lindholm > Sent: Wednesday, April 1, 2020 8:23 PM > To: Pankaj Bansal (OSS) > Cc: Meenakshi Aggarwal ; Michael D Kinney > ; devel@edk2.groups.io; Varun Sethi > ; Samer El-Haj-Mahmoud mahm...@arm.com>; Jon Nettleton > Subject: Re: [PATCH v2 21/28] Sli

Re: [edk2-devel] [PATCH v2 21/28] Slicon/NXP: Add PlatformPei Lib

2020-04-01 Thread Leif Lindholm
On Fri, Mar 20, 2020 at 20:05:36 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > PlatformPeiLib is going to be linked to Platform PEIM. > > Signed-off-by: Pankaj Bansal > --- > .../Library/PlatformPeiLib/PlatformPeiLib.c | 30 ++ > .../Library/PlatformPeiLib/PlatformPeiLib.

[edk2-devel] [PATCH v2 21/28] Slicon/NXP: Add PlatformPei Lib

2020-03-19 Thread Pankaj Bansal
From: Pankaj Bansal PlatformPeiLib is going to be linked to Platform PEIM. Signed-off-by: Pankaj Bansal --- .../Library/PlatformPeiLib/PlatformPeiLib.c | 30 ++ .../Library/PlatformPeiLib/PlatformPeiLib.inf | 41 +++ Silicon/NXP/NxpQoriqLs.dsc.inc|