Sure, I will rename "Fields" and "Data64" in v3 patch.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#78809): https://edk2.groups.io/g/devel/message/78809
Mute This Topic: https://groups.io/mt/84704801/21656
Group Owner: devel+ow...@edk2.
With the renaming, Reviewed-by: Ray Ni
> -Original Message-
> From: Ni, Ray
> Sent: Friday, August 6, 2021 9:55 PM
> To: Lou, Yun ; devel@edk2.groups.io
> Cc: Dong, Eric ; Laszlo Ersek ;
> Kumar, Rahul1
> Subject: RE: [PATCH v2] UefiCpuPkg/CpuCacheInfoLib: Sort CpuCacheInfo array
>
> T
The patch looks good to me. 2 minor comments:
> + } Fields;
1. Can you rename to "Bits" to align to existing naming convention?
>
> + UINT64Data64;
2. Can you rename to "Uint64"?
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3508
Sort the CpuCacheInfo array by CPU package ID, core type, cache level
and cache type.
Signed-off-by: Jason Lou
Cc: Ray Ni
Cc: Eric Dong
Cc: Laszlo Ersek
Cc: Rahul Kumar
---
UefiCpuPkg/Library/CpuCacheInfoLib/CpuCacheInfoLib.c
