Re: [edk2-devel] [PATCH v2] MdeModulePkg: Correct high-memory use in NvmExpressDxe

2022-02-24 Thread Tomas Pilar (tpilar)
On 24/02/2022 13:19, Tomas Pilar (tpilar) wrote: On 24/02/2022 13:14, Tomas Pilar (tpilar) wrote: On 24/02/2022 13:13, Ard Biesheuvel wrote: On Thu, 24 Feb 2022 at 13:58, Tomas Pilar (tpilar) wrote: Move the logic that sets EFI_PCI_IO_ATTRIBUTE_DUAL_ADDRESS_CYCLE Pci attribute to Driv

Re: [edk2-devel] [PATCH v2] MdeModulePkg: Correct high-memory use in NvmExpressDxe

2022-02-24 Thread Tomas Pilar (tpilar)
On 24/02/2022 13:14, Tomas Pilar (tpilar) wrote: On 24/02/2022 13:13, Ard Biesheuvel wrote: On Thu, 24 Feb 2022 at 13:58, Tomas Pilar (tpilar) wrote: Move the logic that sets EFI_PCI_IO_ATTRIBUTE_DUAL_ADDRESS_CYCLE Pci attribute to DriverBindingStart() before the memory that backs the D

Re: [edk2-devel] [PATCH v2] MdeModulePkg: Correct high-memory use in NvmExpressDxe

2022-02-24 Thread Tomas Pilar (tpilar)
On 24/02/2022 13:13, Ard Biesheuvel wrote: On Thu, 24 Feb 2022 at 13:58, Tomas Pilar (tpilar) wrote: Move the logic that sets EFI_PCI_IO_ATTRIBUTE_DUAL_ADDRESS_CYCLE Pci attribute to DriverBindingStart() before the memory that backs the DMA engine is allocated. This ensures that the DMA

Re: [edk2-devel] [PATCH v2] MdeModulePkg: Correct high-memory use in NvmExpressDxe

2022-02-24 Thread Ard Biesheuvel
On Thu, 24 Feb 2022 at 13:58, Tomas Pilar (tpilar) wrote: > > Move the logic that sets EFI_PCI_IO_ATTRIBUTE_DUAL_ADDRESS_CYCLE Pci > > attribute to DriverBindingStart() before the memory that backs the > > DMA engine is allocated. > > > > This ensures that the DMA-backing memory is not forcibly al

[edk2-devel] [PATCH v2] MdeModulePkg: Correct high-memory use in NvmExpressDxe

2022-02-24 Thread Tomas Pilar (tpilar)
Move the logic that sets EFI_PCI_IO_ATTRIBUTE_DUAL_ADDRESS_CYCLE Pci attribute to DriverBindingStart() before the memory that backs the DMA engine is allocated. This ensures that the DMA-backing memory is not forcibly allocated below 4G in system address map. Otherwise the allocation fails on