Re: [edk2-devel] [PATCH v1 5/6] ArmVirtPkg: Kvmtool: Increase primary core stack size

2023-05-18 Thread Sami Mujawar
Hi Ard, On Thu, May 18, 2023 at 08:17 AM, Ard Biesheuvel wrote: > > Given the wider discussion we had the other day about tightening > memory protections, I think it is important that we get this fixed but > I don't think there is any urgency to it. I sent some patches a couple > of months ago t

Re: [edk2-devel] [PATCH v1 5/6] ArmVirtPkg: Kvmtool: Increase primary core stack size

2023-05-18 Thread Ard Biesheuvel
On Thu, 18 May 2023 at 17:12, Sami Mujawar wrote: > > Hi Ard, > > Thank you for the feedback and for the pointers. > > Please see my response inline marked [SAMI]. > > Regards, > > Sami Mujawar > > On 18/05/2023 12:01 pm, Ard Biesheuvel via groups.io wrote: > > On Thu, 18 May 2023 at 11:10, Sami M

Re: [edk2-devel] [PATCH v1 5/6] ArmVirtPkg: Kvmtool: Increase primary core stack size

2023-05-18 Thread Sami Mujawar
Hi Ard, Thank you for the feedback and for the pointers. Please see my response inline marked [SAMI]. Regards, Sami Mujawar On 18/05/2023 12:01 pm, Ard Biesheuvel via groups.io wrote: On Thu, 18 May 2023 at 11:10, Sami Mujawar wrote: The patch "f07a9df9af60 ArmVirtPkg: Enable stack guard"

Re: [edk2-devel] [PATCH v1 5/6] ArmVirtPkg: Kvmtool: Increase primary core stack size

2023-05-18 Thread Ard Biesheuvel
On Thu, 18 May 2023 at 11:10, Sami Mujawar wrote: > > The patch "f07a9df9af60 ArmVirtPkg: Enable stack guard" > enabled stack overflow detection for ArmVirtPkg. Following > this patch, running UEFI shell command 'dmpstore' resulted > in a crash indicating a stack overflow. Invoking 'dmpstore' > re

[edk2-devel] [PATCH v1 5/6] ArmVirtPkg: Kvmtool: Increase primary core stack size

2023-05-18 Thread Sami Mujawar
The patch "f07a9df9af60 ArmVirtPkg: Enable stack guard" enabled stack overflow detection for ArmVirtPkg. Following this patch, running UEFI shell command 'dmpstore' resulted in a crash indicating a stack overflow. Invoking 'dmpstore' results in recursive calls to CascadeProcessVariables () which ap