Hi Ard, On Thu, May 18, 2023 at 08:17 AM, Ard Biesheuvel wrote:
> > Given the wider discussion we had the other day about tightening > memory protections, I think it is important that we get this fixed but > I don't think there is any urgency to it. I sent some patches a couple > of months ago to map DxeCore code and data with tightened permissions > as well, and I think we can revisit this in that context the next time > around. > > So for now, just passing the stack size as you suggested above is > sufficient IMO. [SAMI] Thanks, I will submit a v2 series with the changes. I also observed that a similar change would be needed for ArmPlatformPkg/PrePi at https://github.com/tianocore/edk2/blob/master/ArmPlatformPkg/PrePi/PrePi.c#L164 As of now we do not enable PcdCpuStackGuard in edk2-platforms\Platform\ARM\VExpressPkg\ArmVExpress.dsc.inc But if this is done the same stack overflow issue is seen on the FVP model. Considering that, should I send out a patch for ArmPlatformPkg/PrePi as well? Also, I think it be good to enable the stack guard check in edk2-platforms\Platform\ARM\VExpressPkg\ArmVExpress.dsc.inc. Please let me know your thoughts about this. [/SAMI] Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#105038): https://edk2.groups.io/g/devel/message/105038 Mute This Topic: https://groups.io/mt/98987538/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
