Re: [edk2-devel] [PATCH V7 25/37] MdeModulePkg: EFER should not be changed in TDX

2022-03-03 Thread Wang, Jian J
Ok for me. Regards, Jian > -Original Message- > From: Xu, Min M > Sent: Friday, March 04, 2022 8:19 AM > To: Wang, Jian J ; devel@edk2.groups.io > Cc: Wu, Hao A ; Brijesh Singh ; > Aktas, Erdem ; James Bottomley > ; Yao, Jiewen ; Tom Lendacky > ; Gerd Hoffmann > Subject: RE: [PATCH V7 2

Re: [edk2-devel] [PATCH V7 25/37] MdeModulePkg: EFER should not be changed in TDX

2022-03-03 Thread Min Xu
On March 3, 2022 11:12 AM, Wang Jian wrote: > > Hi Min, > > I think the PCD should not be dynamic. Dynamic PCD is used for those > features which can be changed at boot time. But, for Intel processor, it > should always stay as FALSE. So there's no need to make it dynamic. > FixedAtBuild should b

Re: [edk2-devel] [PATCH V7 25/37] MdeModulePkg: EFER should not be changed in TDX

2022-03-02 Thread Wang, Jian J
Hi Min, I think the PCD should not be dynamic. Dynamic PCD is used for those features which can be changed at boot time. But, for Intel processor, it should always stay as FALSE. So there's no need to make it dynamic. FixedAtBuild should be fine. Regards, Jian > -Original Message- > Fro

[edk2-devel] [PATCH V7 25/37] MdeModulePkg: EFER should not be changed in TDX

2022-02-27 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 In TDX IA32_ERER is RO to host VMM. It could not be changed. PcdIa32EferChangeAllowed is added in MdeModulePkg.dec and it is to be set to FALSE in Tdx guest. Cc: Jian J Wang Cc: Hao A Wu Cc: Brijesh Singh Cc: Erdem Aktas Cc: James Botto