On 2019-06-18 07:26, Liming Gao wrote:
> Rebecca:
> Thanks for your report. Now, pylama is not the requirement for BaseTools
> python script. Patch contributor can base on the report to fix the critical
> issue.
I know it's not a required tool, but many of these are common Python
style issue
; From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Liming
> Gao
> Sent: Tuesday, June 18, 2019 9:15 PM
> To: Kinney, Michael D ; Fan, ZhijuX
> ; devel@edk2.groups.io
> Cc: Feng, Bob C ; Zhang, Shenglei
>
> Subject: Re: [edk2-devel] [PATCH V2] BaseTool
> rebe...@bluestop.org
> Sent: Tuesday, June 18, 2019 3:05 AM
> To: devel@edk2.groups.io; Fan, ZhijuX
> Cc: Gao, Liming ; Feng, Bob C ;
> Zhang, Shenglei ; Kinney,
> Michael D
> Subject: Re: [edk2-devel] [PATCH V2] BaseTools/GenBiosId: Add a new tool
> GenBiosId
>
> On
Mike:
I agree this suggestion. How about introduce -ot option for text file to
include this string?
Thanks
Liming
> -Original Message-
> From: Kinney, Michael D
> Sent: Tuesday, June 18, 2019 1:18 AM
> To: Fan, ZhijuX ; devel@edk2.groups.io; Kinney, Michael
> D
> Cc: Gao, Liming ; Fen
On 2019-06-17 04:54, Fan, ZhijuX wrote:
> +_ConfigSectionNotDefine = "Not support the config file format, need config
> section"
This might be better worded as:
"Invalid config file format: need a config section"
Or maybe:
"Unsupported config file format: need a config section"
--
Rebecc
On 2019-06-17 04:54, Fan, ZhijuX wrote:
> GenBiosId is a tool to generate the BIOS ID binary file which uses
> the data from the configuration file.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1846
pylama (https://github.com/klen/pylama) reports the following issues:
bcran@photon:~/workspa
We would like to move to Python based tools for
everything with no requirements to use batch files
or shell scripts.
Do we really need the -ob --batch flag? I looks
like the feature it provides is a text string of the
BIOSID. Can't we send that to stdout or just put
that text string in an out
GenBiosId is a tool to generate the BIOS ID binary file which uses
the data from the configuration file.
https://bugzilla.tianocore.org/show_bug.cgi?id=1846
v2:v1 is a tool of C type and v2 is python type.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
BaseTools/BinWrappers/Pos
