Rebecca: Thanks for your report. Now, pylama is not the requirement for BaseTools python script. Patch contributor can base on the report to fix the critical issue.
Thanks Liming > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > rebe...@bluestop.org > Sent: Tuesday, June 18, 2019 3:05 AM > To: devel@edk2.groups.io; Fan, ZhijuX <zhijux....@intel.com> > Cc: Gao, Liming <liming....@intel.com>; Feng, Bob C <bob.c.f...@intel.com>; > Zhang, Shenglei <shenglei.zh...@intel.com>; Kinney, > Michael D <michael.d.kin...@intel.com> > Subject: Re: [edk2-devel] [PATCH V2] BaseTools/GenBiosId: Add a new tool > GenBiosId > > On 2019-06-17 04:54, Fan, ZhijuX wrote: > > GenBiosId is a tool to generate the BIOS ID binary file which uses > > the data from the configuration file. > > https://bugzilla.tianocore.org/show_bug.cgi?id=1846 > > > pylama (https://github.com/klen/pylama) reports the following issues: > > > bcran@photon:~/workspace/edk2/BaseTools/Source/Python/GenBiosId % pylama . > GenBiosId.py:1:1: E266 too many leading '#' for block comment [pycodestyle] > GenBiosId.py:19:1: E722 do not use bare 'except' [pycodestyle] > GenBiosId.py:21:1: W0401 'from Common.BuildToolError import *' used; > unable to detect undefined names [pyflakes] > GenBiosId.py:22:1: W0401 'from Common.Misc import *' used; unable to > detect undefined names [pyflakes] > GenBiosId.py:23:1: W0401 'from Common.DataType import *' used; unable to > detect undefined names [pyflakes] > GenBiosId.py:24:1: W0611 'Common.BuildVersion.gBUILD_VERSION' imported > but unused [pyflakes] > GenBiosId.py:34:80: E501 line too long (82 > 79 characters) [pycodestyle] > GenBiosId.py:38:17: E203 whitespace before ':' [pycodestyle] > GenBiosId.py:38:28: E203 whitespace before ':' [pycodestyle] > GenBiosId.py:38:43: E203 whitespace before ':' [pycodestyle] > GenBiosId.py:39:17: E203 whitespace before ':' [pycodestyle] > GenBiosId.py:39:28: E203 whitespace before ':' [pycodestyle] > GenBiosId.py:39:43: E203 whitespace before ':' [pycodestyle] > GenBiosId.py:40:17: E203 whitespace before ':' [pycodestyle] > GenBiosId.py:40:21: E201 whitespace after '{' [pycodestyle] > GenBiosId.py:40:29: E203 whitespace before ':' [pycodestyle] > GenBiosId.py:40:44: E203 whitespace before ':' [pycodestyle] > GenBiosId.py:41:17: E203 whitespace before ':' [pycodestyle] > GenBiosId.py:41:28: E203 whitespace before ':' [pycodestyle] > GenBiosId.py:41:43: E203 whitespace before ':' [pycodestyle] > GenBiosId.py:41:44: E231 missing whitespace after ':' [pycodestyle] > GenBiosId.py:42:20: E203 whitespace before ':' [pycodestyle] > GenBiosId.py:42:31: E203 whitespace before ':' [pycodestyle] > GenBiosId.py:42:50: E203 whitespace before ':' [pycodestyle] > GenBiosId.py:43:20: E203 whitespace before ':' [pycodestyle] > GenBiosId.py:43:31: E203 whitespace before ':' [pycodestyle] > GenBiosId.py:43:48: E203 whitespace before ':' [pycodestyle] > GenBiosId.py:49:80: E501 line too long (83 > 79 characters) [pycodestyle] > GenBiosId.py:53:1: E302 expected 2 blank lines, found 1 [pycodestyle] > GenBiosId.py:53:1: C901 'Main' is too complex (17) [mccabe] > GenBiosId.py:55:80: E501 line too long (90 > 79 characters) [pycodestyle] > GenBiosId.py:57:80: E501 line too long (81 > 79 characters) [pycodestyle] > GenBiosId.py:59:80: E501 line too long (102 > 79 characters) [pycodestyle] > GenBiosId.py:60:80: E501 line too long (97 > 79 characters) [pycodestyle] > GenBiosId.py:61:80: E501 line too long (110 > 79 characters) [pycodestyle] > GenBiosId.py:65:80: E501 line too long (86 > 79 characters) [pycodestyle] > GenBiosId.py:65:28: E225 missing whitespace around operator [pycodestyle] > GenBiosId.py:66:1: W0401 'OPTION_MISSING may be undefined, or defined > from star imports: Common.BuildToolError, Common.DataType, Common.Misc' > [pyflakes] > GenBiosId.py:68:1: W0401 'OPTION_MISSING may be undefined, or defined > from star imports: Common.BuildToolError, Common.DataType, Common.Misc' > [pyflakes] > GenBiosId.py:69:1: W0401 'FatalError may be undefined, or defined from > star imports: Common.BuildToolError, Common.DataType, Common.Misc' > [pyflakes] > GenBiosId.py:69:1: W0612 local variable 'X' is assigned to but never > used [pyflakes] > GenBiosId.py:75:80: E501 line too long (86 > 79 characters) [pycodestyle] > GenBiosId.py:75:1: W0401 'FILE_NOT_FOUND may be undefined, or defined > from star imports: Common.BuildToolError, Common.DataType, Common.Misc' > [pyflakes] > GenBiosId.py:80:80: E501 line too long (93 > 79 characters) [pycodestyle] > GenBiosId.py:80:1: W0401 'FORMAT_NOT_SUPPORTED may be undefined, or > defined from star imports: Common.BuildToolError, Common.DataType, > Common.Misc' [pyflakes] > GenBiosId.py:85:80: E501 line too long (93 > 79 characters) [pycodestyle] > GenBiosId.py:85:1: W0401 'FORMAT_INVALID may be undefined, or defined > from star imports: Common.BuildToolError, Common.DataType, Common.Misc' > [pyflakes] > GenBiosId.py:88:80: E501 line too long (92 > 79 characters) [pycodestyle] > GenBiosId.py:88:1: W0401 'FORMAT_INVALID may be undefined, or defined > from star imports: Common.BuildToolError, Common.DataType, Common.Misc' > [pyflakes] > GenBiosId.py:91:80: E501 line too long (101 > 79 characters) [pycodestyle] > GenBiosId.py:91:1: W0401 'FORMAT_UNKNOWN_ERROR may be undefined, or > defined from star imports: Common.BuildToolError, Common.DataType, > Common.Misc' [pyflakes] > GenBiosId.py:95:80: E501 line too long (173 > 79 characters) [pycodestyle] > GenBiosId.py:96:80: E501 line too long (111 > 79 characters) [pycodestyle] > GenBiosId.py:96:14: E127 continuation line over-indented for visual > indent [pycodestyle] > GenBiosId.py:114:1: E305 expected 2 blank lines after class or function > definition, found 1 [pycodestyle] > GenBiosId.py:116:5: E266 too many leading '#' for block comment > [pycodestyle] > GenBiosId.py:117:24: E701 multiple statements on one line (colon) > [pycodestyle] > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#42543): https://edk2.groups.io/g/devel/message/42543 Mute This Topic: https://groups.io/mt/32093449/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
