Re: [edk2-devel] [PATCH 2/5] MdePkg: Allow PcdFSBClock to by Dynamic

2020-02-03 Thread Liming Gao
o Ersek ; devel@edk2.groups.io; Kinney, Michael D > ; Ard Biesheuvel > ; xen-de...@lists.xenproject.org; Justen, Jordan L > ; Julien Grall > ; Feng, Bob C > Subject: Re: [edk2-devel] [PATCH 2/5] MdePkg: Allow PcdFSBClock to by Dynamic > > On Mon, Feb 03, 2020 at 03:34:07PM

Re: [edk2-devel] [PATCH 2/5] MdePkg: Allow PcdFSBClock to by Dynamic

2020-02-03 Thread Anthony PERARD
On Mon, Feb 03, 2020 at 03:34:07PM +, Anthony PERARD wrote: > On Mon, Feb 03, 2020 at 01:34:55AM +, Gao, Liming wrote: > > Anthony: > > This change is OK to me. But if this PCD is configured as Dynamic, its > > value will be got from PCD service. This operation will take some time and >

Re: [edk2-devel] [PATCH 2/5] MdePkg: Allow PcdFSBClock to by Dynamic

2020-02-03 Thread Anthony PERARD
On Mon, Feb 03, 2020 at 01:34:55AM +, Gao, Liming wrote: > Anthony: > This change is OK to me. But if this PCD is configured as Dynamic, its > value will be got from PCD service. This operation will take some time and > cause the inaccurate time delay. Have you measured its impact? No, I h

Re: [edk2-devel] [PATCH 2/5] MdePkg: Allow PcdFSBClock to by Dynamic

2020-02-02 Thread Liming Gao
Anthony: This change is OK to me. But if this PCD is configured as Dynamic, its value will be got from PCD service. This operation will take some time and cause the inaccurate time delay. Have you measured its impact? Thanks Liming > -Original Message- > From: Laszlo Ersek > Sent: Thu

Re: [edk2-devel] [PATCH 2/5] MdePkg: Allow PcdFSBClock to by Dynamic

2020-01-29 Thread Laszlo Ersek
On 01/29/20 13:12, Anthony PERARD wrote: > We are going to want to change the value of PcdFSBClock at run time in > OvmfXen, so move it to the PcdsDynamic section. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2490 > Signed-off-by: Anthony PERARD > --- > CC: Bob Feng > CC: Liming Gao

[edk2-devel] [PATCH 2/5] MdePkg: Allow PcdFSBClock to by Dynamic

2020-01-29 Thread Anthony PERARD
We are going to want to change the value of PcdFSBClock at run time in OvmfXen, so move it to the PcdsDynamic section. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2490 Signed-off-by: Anthony PERARD --- CC: Bob Feng CC: Liming Gao --- MdePkg/MdePkg.dec | 8 1 file changed, 4 in