Re: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix driver binding start issue.

2023-07-24 Thread Michael D Kinney
move comma: "Lendacky, Thomas via groups.io" * Remove double quotes around name: "Lendacky, Thomas via groups.io" * Remove via from another source from name: "Lendacky, Thomas via groups.io" * The email address must not contain any '=': thomas.lendacky=amd.

Re: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix driver binding start issue.

2023-07-20 Thread Ard Biesheuvel
On Thu, 20 Jul 2023 at 19:10, Michael D Kinney wrote: > > Hi Ard, > > This is my mistake. I usually check the Author field when > adding Rb/Ab tags because I have seen lots of cases where > the Author field needs updating as well. I forgot to do this > step in this one. > > I agree a CI check ag

Re: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix driver binding start issue.

2023-07-20 Thread Michael D Kinney
Miki > Cc: Kasbekar, Saloni ; Nickle Wang > ; Clark-williams, Zachary willi...@intel.com>; Abner Chang ; Igor Kulchytskyy > ; Nick Ramirez > Subject: Re: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix driver > binding start issue. > > On Thu, 20 Jul 2023 at 03:41, Mic

Re: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix driver binding start issue.

2023-07-20 Thread Ard Biesheuvel
nney, Michael D > > Sent: Wednesday, July 19, 2023 5:27 PM > > To: Kasbekar, Saloni ; Nickle Wang > > ; devel@edk2.groups.io; Clark-williams, Zachary > > > > Cc: Abner Chang ; Igor Kulchytskyy ; > > Nick Ramirez ; Kinney, Michael D > > > > Su

Re: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix driver binding start issue.

2023-07-19 Thread Michael D Kinney
Kulchytskyy ; > Nick Ramirez ; Kinney, Michael D > > Subject: RE: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix driver > binding start issue. > > Acked-by: Michael D Kinney > > > -Original Message- > > From: Kasbekar, Saloni > > Sent: Thursday, July

Re: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix driver binding start issue.

2023-07-19 Thread Michael D Kinney
11:54 PM > To: devel@edk2.groups.io; Kasbekar, Saloni ; > Clark-williams, Zachary > Cc: Abner Chang ; Igor Kulchytskyy ; > Nick Ramirez > Subject: RE: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix driver > binding start issue. > > Hi Saloni, > > Could you please

Re: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix driver binding start issue.

2023-07-13 Thread Saloni Kasbekar
groups.io > Sent: Friday, June 30, 2023 6:28 AM > To: Nickle Wang ; devel@edk2.groups.io > Cc: Maciej Rabeda ; Siyuan Fu > ; Abner Chang ; Igor > Kulchytskyy ; Nick Ramirez > Subject: Re: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix driver > binding start issue. > >

Re: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix driver binding start issue.

2023-07-12 Thread Nickle Wang via groups.io
ng ; devel@edk2.groups.io > Cc: Maciej Rabeda ; Siyuan Fu > ; Abner Chang ; Igor Kulchytskyy > ; Nick Ramirez > Subject: Re: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix driver binding > start issue. > > External email: Use caution opening links or attachments > > > Hi

Re: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix driver binding start issue.

2023-06-29 Thread Saloni Kasbekar
Kulchytskyy ; Nick Ramirez Subject: RE: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix driver binding start issue. Hi Saloni, Thanks for your review. When uninstall fails, per UEFI specification, the protocol will be installed again and will be visible to UEFI drivers. Page 190, UEFI spec. 2.10

Re: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix driver binding start issue.

2023-06-28 Thread Nickle Wang via groups.io
Kulchytskyy > ; Nick Ramirez > Subject: RE: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix driver binding > start issue. > > External email: Use caution opening links or attachments > > > Hi Nickle, > > We would want to do the FreePool even if the Uninstall fails (

Re: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix driver binding start issue.

2023-06-28 Thread Saloni Kasbekar
ps.io; Nickle Wang Cc: Maciej Rabeda ; Siyuan Fu ; Abner Chang ; Igor Kulchytskyy ; Nick Ramirez Subject: Re: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix driver binding start issue. May I know if someone can help to review this patch? Thanks, Nickle > -Original Message- &g

Re: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix driver binding start issue.

2023-06-27 Thread Nickle Wang via groups.io
; Abner Chang ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix driver binding start > issue. > > External email: Use caution opening links or attachments > > > When failure happens in HttpDxeStart, the error handling cod

[edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix driver binding start issue.

2023-02-10 Thread Nickle Wang via groups.io
When failure happens in HttpDxeStart, the error handling code release the memory buffer but it does not uninstall HTTP service bindnig protocol. As the result, application can still locate this protocol and invoke service binding fucntions in released memory pool. Signed-off-by: Nickle Wang Cc: M