May I know if someone can help to review this patch? Thanks, Nickle
> -----Original Message----- > From: [email protected] <[email protected]> On Behalf Of Nickle Wang > via groups.io > Sent: Friday, February 10, 2023 8:34 PM > To: [email protected] > Cc: Maciej Rabeda <[email protected]>; Siyuan Fu > <[email protected]>; Abner Chang <[email protected]>; Igor Kulchytskyy > <[email protected]>; Nick Ramirez <[email protected]> > Subject: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix driver binding start > issue. > > External email: Use caution opening links or attachments > > > When failure happens in HttpDxeStart, the error handling code release the > memory buffer but it does not uninstall HTTP service bindnig protocol. As the > result, application can still locate this protocol and invoke service binding > fucntions > in released memory pool. > > Signed-off-by: Nickle Wang <[email protected]> > Cc: Maciej Rabeda <[email protected]> > Cc: Siyuan Fu <[email protected]> > Cc: Abner Chang <[email protected]> > Cc: Igor Kulchytskyy <[email protected]> > Cc: Nick Ramirez <[email protected]> > --- > NetworkPkg/HttpDxe/HttpDriver.c | 13 +++++++++++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > diff --git a/NetworkPkg/HttpDxe/HttpDriver.c > b/NetworkPkg/HttpDxe/HttpDriver.c index 5d918d3c4d..f6d1263cad 100644 > --- a/NetworkPkg/HttpDxe/HttpDriver.c > +++ b/NetworkPkg/HttpDxe/HttpDriver.c > @@ -3,6 +3,7 @@ > > Copyright (c) 2015 - 2018, Intel Corporation. All rights reserved.<BR> > (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR> > + Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. > > SPDX-License-Identifier: BSD-2-Clause-Patent > > @@ -464,8 +465,16 @@ ON_ERROR: > > if (HttpService != NULL) { > HttpCleanService (HttpService, UsingIpv6); > - if ((HttpService->Tcp4ChildHandle == NULL) && (HttpService- > >Tcp6ChildHandle == NULL)) { > - FreePool (HttpService); > + Status = gBS->UninstallMultipleProtocolInterfaces ( > + &ControllerHandle, > + &gEfiHttpServiceBindingProtocolGuid, > + &HttpService->ServiceBinding, > + NULL > + ); > + if (!EFI_ERROR (Status)) { > + if ((HttpService->Tcp4ChildHandle == NULL) && (HttpService- > >Tcp6ChildHandle == NULL)) { > + FreePool (HttpService); > + } > } > } > > -- > 2.39.1.windows.1 > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#106451): https://edk2.groups.io/g/devel/message/106451 Mute This Topic: https://groups.io/mt/99821789/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
