Re: [edk2-devel] [PATCH 13/13] OvmfPkg/BaseMemEncryptSevLib: remove Flush parameter

2021-05-13 Thread Laszlo Ersek
On 05/12/21 18:35, Brijesh Singh wrote: > > On 5/11/21 12:45 PM, Brijesh Singh wrote: >> 1) Drop the cache flush param from high level >> MemEncryptSev{Set,Clear}PageEncMask and don't touch anything in the >> SetMemoryEncDec() >> >> 2) Rename the Flush parameter to Mmio in the SetMemoryEncDec() >

Re: [edk2-devel] [PATCH 13/13] OvmfPkg/BaseMemEncryptSevLib: remove Flush parameter

2021-05-13 Thread Laszlo Ersek
On 05/11/21 19:45, Brijesh Singh wrote: > TheĀ  internal function is used for clearing the mask for both system RAM > as well as Mmio, so we need a way to tell the internal function that > call is for the Mmio range. I thought making all the changes in a single > file makes sense but I see it can g

Re: [edk2-devel] [PATCH 13/13] OvmfPkg/BaseMemEncryptSevLib: remove Flush parameter

2021-05-12 Thread Brijesh Singh
On 5/11/21 12:45 PM, Brijesh Singh wrote: > On 5/11/21 6:55 AM, Laszlo Ersek wrote: >> I don't fully understand the updates in this patch: >> >> On 05/07/21 22:38, Brijesh Singh wrote: >>> BZ: >>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug

Re: [edk2-devel] [PATCH 13/13] OvmfPkg/BaseMemEncryptSevLib: remove Flush parameter

2021-05-11 Thread Brijesh Singh
On 5/11/21 6:55 AM, Laszlo Ersek wrote: > I don't fully understand the updates in this patch: > > On 05/07/21 22:38, Brijesh Singh wrote: >> BZ: >> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3275&data=04%7C01%7Cbrijesh.singh%40a

Re: [edk2-devel] [PATCH 13/13] OvmfPkg/BaseMemEncryptSevLib: remove Flush parameter

2021-05-11 Thread Laszlo Ersek
I don't fully understand the updates in this patch: On 05/07/21 22:38, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > The Flush parameter is used to provide a hint whether the specified range > is Mmio address. Now that we have a dedicated helper to clear the >

[edk2-devel] [PATCH 13/13] OvmfPkg/BaseMemEncryptSevLib: remove Flush parameter

2021-05-07 Thread Brijesh Singh
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 The Flush parameter is used to provide a hint whether the specified range is Mmio address. Now that we have a dedicated helper to clear the memory encryption mask for the Mmio address range, its safe to remove the Flush parameter from MemEncr