Re: [edk2-devel] [PATCH 1/3] BaseTools: Let the GetMaintainer.py script be executable

2019-10-17 Thread Bob Feng
Hi Phil, To make python script to be executable, I think only change file permission would not be enough. There also need to be a shebang #!/usr/bin/env python at the top of this script. But from the patch 3/3, I see in the GitCcCmd.sh, GetMaintainer.py is called by "python ${EDK_TOOLS_PATH}/Sc

[edk2-devel] [PATCH 1/3] BaseTools: Let the GetMaintainer.py script be executable

2019-10-16 Thread Philippe Mathieu-Daudé
The GetMaintainer.py script use the "if __name__ == '__main__'" evaluation so it expects to be run as a standalone program. We have other Python scripts with the executable permission, let this one be executable too. Signed-off-by: Philippe Mathieu-Daude --- BaseTools/Scripts/GetMaintainer.py |