zlo
>
>> -Original Message-
>> From: David Woodhouse
>> Sent: Tuesday, June 25, 2019 2:06 PM
>> To: Laszlo Ersek ; devel@edk2.groups.io;
>> jljus...@gmail.com; af...@apple.com; Paolo Bonzini
>> Cc: Ni, Ray
>> Subject: Re: [edk2-devel] [PATCH
On Tue, 2019-06-25 at 00:08 +0200, Laszlo Ersek wrote:
> > But we could consider that a second step. If I make the LegacyBm code
> > just call the existing (but renamed) EfiBootManagerGetBootDescription()
> > then all the horrid special cases and the specification work that's
> > required to fix th
dk2-devel] [PATCH 1/2] LegacyBios: set NumberBbsEntries to
> the size of BbsTable
>
>
>
> On 24 June 2019 23:22:03 BST, Laszlo Ersek wrote:
> >Wait, we already have EfiBootManagerRegisterBootDescriptionHandler().
> >Could that help?
>
> No, that allows you to reg
On 06/25/19 00:08, Laszlo Ersek wrote:
> On 06/21/19 12:59, David Woodhouse wrote:
>> Adding a generic way for block devices to report a human-readable
>> description in order to kill off all the device-type-specific functions
>> in BmBootDescription.c presumably *would* involve actually coordinat
On 06/21/19 12:59, David Woodhouse wrote:
> On Thu, 2019-06-20 at 22:35 +0200, Laszlo Ersek wrote:
I think your note on patch#2 is valuable too and should be captured in
the commit message body. Please consider formulating it with a bit more
neutral tone :)
>>>
>>> I would prefer to
On 06/24/19 13:48, David Woodhouse wrote:
> On Thu, 2019-06-20 at 22:35 +0200, Laszlo Ersek wrote:
>> My past mistake doesn't excuse the current commit message ;)
>>
>> Anyway, I intentionally didn't ask for just repeating the commit msg
>> title in the commit msg body. You could mention why the pr
On Thu, 2019-06-20 at 22:35 +0200, Laszlo Ersek wrote:
> My past mistake doesn't excuse the current commit message ;)
>
> Anyway, I intentionally didn't ask for just repeating the commit msg
> title in the commit msg body. You could mention why the pre-patch
> expression (1 + 2 * MAX_IDE_CONTROLLE
On Thu, 2019-06-20 at 22:35 +0200, Laszlo Ersek wrote:
> > > I think your note on patch#2 is valuable too and should be captured in
> > > the commit message body. Please consider formulating it with a bit more
> > > neutral tone :)
> >
> > I would prefer to express that particular concern in 'diff
On 06/20/19 19:32, David Woodhouse wrote:
> On Thu, 2019-06-20 at 18:12 +0200, Laszlo Ersek wrote:
>> If it's possible, please write a non-empty commit message body, for each
>> patch in this series. Just one sentence on this patch would be nice.
>
>
> The comnit comment isn't empty. It has one s
On Thu, 2019-06-20 at 18:12 +0200, Laszlo Ersek wrote:
> If it's possible, please write a non-empty commit message body, for each
> patch in this series. Just one sentence on this patch would be nice.
The comnit comment isn't empty. It has one sentence "LegacyBios: set
NumberBbsEntries to the siz
On 06/19/19 14:44, David Woodhouse wrote:
> Signed-off-by: David Woodhouse
> ---
> OvmfPkg/Csm/LegacyBiosDxe/LegacyBios.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/OvmfPkg/Csm/LegacyBiosDxe/LegacyBios.c
> b/OvmfPkg/Csm/LegacyBiosDxe/LegacyBios.c
> index 05e3ffd2bb
Signed-off-by: David Woodhouse
---
OvmfPkg/Csm/LegacyBiosDxe/LegacyBios.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/OvmfPkg/Csm/LegacyBiosDxe/LegacyBios.c
b/OvmfPkg/Csm/LegacyBiosDxe/LegacyBios.c
index 05e3ffd2bb..69abd06c40 100644
--- a/OvmfPkg/Csm/LegacyBiosDxe/Legacy
12 matches
Mail list logo
