On Thu, 2019-06-20 at 18:12 +0200, Laszlo Ersek wrote: > If it's possible, please write a non-empty commit message body, for each > patch in this series. Just one sentence on this patch would be nice.
The comnit comment isn't empty. It has one sentence "LegacyBios: set NumberBbsEntries to the size of BbsTable". A second sentence would be redundant and render the description larger than the patch itself. I can't think of anything useful I'd want to put in it. Apparently neither could you when you posted the same patch in 2013 after splitting it out from a larger patch of mine. :) https://www.mail-archive.com/edk2-devel@lists.sourceforge.net/msg01618.html > I think your note on patch#2 is valuable too and should be captured in > the commit message body. Please consider formulating it with a bit more > neutral tone :) I would prefer to express that particular concern in 'diff -up' form when actually fixing it :) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#42659): https://edk2.groups.io/g/devel/message/42659 Mute This Topic: https://groups.io/mt/32122467/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
smime.p7s
Description: S/MIME cryptographic signature
