t; From: kra...@redhat.com
> > Sent: Wednesday, May 3, 2023 3:24 PM
> > To: Ni, Ray
> > Cc: devel@edk2.groups.io; Pawel Polawski ; Kumar,
> > Rahul R ; Oliver Steffen ;
> > Dong, Eric
> > Subject: Re: [edk2-devel] [PATCH 1/1] UefiCpuPkg/MpInitLib: fix apic mo
; Rahul R ; Oliver Steffen ;
> Dong, Eric
> Subject: Re: [edk2-devel] [PATCH 1/1] UefiCpuPkg/MpInitLib: fix apic mode
> for cpu hotplug
>
> On Tue, Mar 21, 2023 at 07:28:44AM +, Ni, Ray wrote:
> > > + } else if ((PcdGet32 (PcdCpuBootLogicalProcessorNum
On Tue, Mar 21, 2023 at 07:28:44AM +, Ni, Ray wrote:
> > + } else if ((PcdGet32 (PcdCpuBootLogicalProcessorNumber) > 0) &&
> > + (PcdGet32 (PcdCpuMaxLogicalProcessorNumber) > 255))
> > + {
> > +X2Apic = TRUE;
>
> Gerd,
> I agree with your needs that want X2 APIC even the actu
t; Subject: Re: [edk2-devel] [PATCH 1/1] UefiCpuPkg/MpInitLib: fix apic mode
> for cpu hotplug
>
> On Tue, Mar 21, 2023 at 07:28:44AM +, Ni, Ray wrote:
> > > + } else if ((PcdGet32 (PcdCpuBootLogicalProcessorNumber) > 0) &&
> > > + (PcdGet32 (PcdC
On Tue, Mar 21, 2023 at 07:28:44AM +, Ni, Ray wrote:
> > + } else if ((PcdGet32 (PcdCpuBootLogicalProcessorNumber) > 0) &&
> > + (PcdGet32 (PcdCpuMaxLogicalProcessorNumber) > 255))
> > + {
> > +X2Apic = TRUE;
>
> Gerd,
> I agree with your needs that want X2 APIC even the actu
> + } else if ((PcdGet32 (PcdCpuBootLogicalProcessorNumber) > 0) &&
> + (PcdGet32 (PcdCpuMaxLogicalProcessorNumber) > 255))
> + {
> +X2Apic = TRUE;
Gerd,
I agree with your needs that want X2 APIC even the actual processor number in
BIOS phase <= 255.
Question: Is it possible th
On Tue, Mar 07, 2023 at 01:20:37PM +0100, Gerd Hoffmann wrote:
> In case the number of CPUs can in increase beyond 255
> due to CPU hotplug choose x2apic mode.
>
> Signed-off-by: Gerd Hoffmann
Ping. Any comments on this patch?
thanks,
Gerd
> ---
> UefiCpuPkg/Library/MpInitLib/MpLib.c | 8 +
In case the number of CPUs can in increase beyond 255
due to CPU hotplug choose x2apic mode.
Signed-off-by: Gerd Hoffmann
---
UefiCpuPkg/Library/MpInitLib/MpLib.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.c
b/UefiCpuPkg/Library