Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Store PageTablePool in TdxWorkArea

2022-09-26 Thread Min Xu
On September 27, 2022 11:01 AM, Jiewen Yao wrote: > > My feeling is that this mPageTablePool is an driver *internal* data. > It is not the best idea to expose an internal data structure to *public* > space. > > Can we have a way to move mPageTablePool to stack instead of global data > area? such

Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Store PageTablePool in TdxWorkArea

2022-09-26 Thread Yao, Jiewen
> -Original Message- > From: Gerd Hoffmann > Sent: Friday, September 23, 2022 1:44 PM > To: Xu, Min M > Cc: devel@edk2.groups.io; Aktas, Erdem ; > James Bottomley ; Yao, Jiewen > ; Tom Lendacky > Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Store PageTablePool in > T

Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Store PageTablePool in TdxWorkArea

2022-09-22 Thread Gerd Hoffmann
On Thu, Sep 22, 2022 at 04:43:04AM +, Xu, Min M wrote: > Hi, Gerd > Do you have any comments on this patch? Looks ok to me. But I'm increasingly wondering whenever it actually was that a smart move to ditch the PEI phase for the IntelTdx builds. Anything which can't be handled in DXE must be

Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Store PageTablePool in TdxWorkArea

2022-09-21 Thread Min Xu
y ; Yao, Jiewen ; Tom > Lendacky > Subject: [edk2-devel] [PATCH 1/1] OvmfPkg: Store PageTablePool in > TdxWorkArea > > From: Min M Xu > > PeilessStartupLib is running in SEC phase. In that phase global variable is > not > allowed. So the mPageTablePool cannot be used. In st

[edk2-devel] [PATCH 1/1] OvmfPkg: Store PageTablePool in TdxWorkArea

2022-09-06 Thread Min Xu
From: Min M Xu PeilessStartupLib is running in SEC phase. In that phase global variable is not allowed. So the mPageTablePool cannot be used. In stead the PageTablePool is stored in TdxWorkArea. Cc: Erdem Aktas Cc: Gerd Hoffmann Cc: James Bottomley Cc: Jiewen Yao Cc: Tom Lendacky Signed-off