My feeling is that this mPageTablePool is an driver *internal* data. It is not the best idea to expose an internal data structure to *public* space.
Can we have a way to move mPageTablePool to stack instead of global data area? such as input as function parameter? Thank you Yao Jiewen > -----Original Message----- > From: Gerd Hoffmann <kra...@redhat.com> > Sent: Friday, September 23, 2022 1:44 PM > To: Xu, Min M <min.m...@intel.com> > Cc: devel@edk2.groups.io; Aktas, Erdem <erdemak...@google.com>; > James Bottomley <j...@linux.ibm.com>; Yao, Jiewen > <jiewen....@intel.com>; Tom Lendacky <thomas.lenda...@amd.com> > Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Store PageTablePool in > TdxWorkArea > > On Thu, Sep 22, 2022 at 04:43:04AM +0000, Xu, Min M wrote: > > Hi, Gerd > > Do you have any comments on this patch? > > Looks ok to me. > > But I'm increasingly wondering whenever it actually was that a smart > move to ditch the PEI phase for the IntelTdx builds. Anything which > can't be handled in DXE must be done in SEC, and the SEC restrictions > seem to be a constant struggle. > > We had that when adding tdx measurement support which required sha* > hash support for SEC. And this looks like another case ... > > take care, > Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#94384): https://edk2.groups.io/g/devel/message/94384 Mute This Topic: https://groups.io/mt/93517163/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
