Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/XhciDxe: Fix Broken Timeouts

2020-09-01 Thread Laszlo Ersek
Hi Patrick, On 09/01/20 20:55, patrick.h...@hpe.com wrote: > From: henz some meta-comments: (1) Please consider setting the "user.name" item in your git config to your full name, "Patrick Henz". Because right now it seems to be just "henz", and that doesn't look very nice in the git commit hist

[edk2-devel] [PATCH 1/1] MdeModulePkg/XhciDxe: Fix Broken Timeouts

2020-09-01 Thread patrick . henz
From: henz REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2948 Timeouts in the XhciDxe driver are taking longer than expected due to the timeout loops not accounting for code execution time. As en example, 5 second timeouts have been observed to take around 36 seconds to complete. Use SetTim

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/XhciDxe: Fix Broken Timeouts

2020-09-01 Thread Ni, Ray
In general, thanks for enhancing the logic to take the cmd execution duration into the timeout. 2 minor comments: > > + (EFI_TIMER_PERIOD_MICROSECONDS(0x)): 1. Can you enhance the patch to avoid creating the timer event the Timeout is 0. > > + } while (!