Created a PR https://github.com/tianocore/edk2/pull/1580
-Original Message-
From: devel@edk2.groups.io On Behalf Of Bob Feng
Sent: Monday, April 19, 2021 5:13 PM
To: Shi, Steven ; devel@edk2.groups.io
Cc: gaolim...@byosoft.com.cn
Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools: Add
OK.
I also find a similar case in toolsetup.bat line 411
set "PATH=%BASE_TOOLS_PATH%\BinWrappers\WindowsLike;%PATH%"
Reviewed-by: Bob Feng
Thanks,
Bob
-Original Message-
From: Shi, Steven
Sent: Monday, April 19, 2021 4:47 PM
To: Feng, Bob C ; devel@edk2.groups.io
Cc: gaolim...@byosof
Hi Bob,
I tried @set CLANG_BIN="c:\Program Files\LLVM\bin\", but it cannot work with my
CI build service. Only the @set "CLANG_BIN=C:\Program Files\LLVM\bin\" can
works. So, it is necessary to use double quote around the whole setting string,
which includes both "=" left name and right value par
Steven,
Would you do a little change as
@set CLANG_BIN="c:\Program Files\LLVM\bin\"
I think the double quote should be only round the path.
Thanks,
Bob
-Original Message-
From: Shi, Steven
Sent: Saturday, April 17, 2021 8:22 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; gaolim...@byo
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Steven Shi
> 发送时间: 2021年4月17日 20:22
> 收件人: devel@edk2.groups.io
> 抄送: bob.c.f...@intel.com; gaolim...@byosoft.com.cn; Steven Shi
>
> 主题: [edk2-devel] [PATCH 1/1] BaseTools: Add double quote around
&g
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3341
Current CLANG_BIN env variable is set without double quote
around the LLVM default installation path string in windows,
which causes some CI build service cannot find the LLVM path
in windows.
This patch enhance it to add double quote around
