Steven,

Would you do a little change as

@set CLANG_BIN="c:\Program Files\LLVM\bin\"

I think the double quote should be only round the path.

Thanks,
Bob

-----Original Message-----
From: Shi, Steven <steven....@intel.com> 
Sent: Saturday, April 17, 2021 8:22 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C <bob.c.f...@intel.com>; gaolim...@byosoft.com.cn; Shi, Steven 
<steven....@intel.com>
Subject: [PATCH 1/1] BaseTools: Add double quote around CLANG_BIN path string

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3341

Current CLANG_BIN env variable is set without double quote around the LLVM 
default installation path string in windows, which causes some CI build service 
cannot find the LLVM path in windows.
This patch enhance it to add double quote around it.

Signed-off-by: Steven Shi <steven....@intel.com>
Cc: Bob Feng <bob.c.f...@intel.com>
Cc: Liming Gao <gaolim...@byosoft.com.cn>
---
 edksetup.bat | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/edksetup.bat b/edksetup.bat index 7b9377aaa5c2..7ad137bb3e9b 100755
--- a/edksetup.bat
+++ b/edksetup.bat
@@ -120,7 +120,7 @@ if not defined CLANG_BIN (
     @echo.     @echo !!! WARNING !!! CLANG_BIN environment variable is not set 
    @if exist "C:\Program Files\LLVM\bin\clang.exe" (-        @set 
CLANG_BIN=C:\Program Files\LLVM\bin\+        @set "CLANG_BIN=C:\Program 
Files\LLVM\bin\"         @echo   Found LLVM, setting CLANG_BIN environment 
variable to C:\Program Files\LLVM\bin\     ) )-- 
2.28.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#74251): https://edk2.groups.io/g/devel/message/74251
Mute This Topic: https://groups.io/mt/82163598/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to