Re: [edk2-devel] [PATCH 06/10] OvmfPkg: Add TdxStartupLib

2022-01-11 Thread Min Xu
Hi > > > +VOID > > > +Split2MPageTo4K ( > > > > Yet another copy of this. Please don't. > I will figure out a Page walker lib so that these duplicated code can be > avoided. Thanks for reminder. After I implemented a PoC of PageTable library, I realized that there has already been a same feature

Re: [edk2-devel] [PATCH 06/10] OvmfPkg: Add TdxStartupLib

2021-12-16 Thread Min Xu
On December 15, 2021 6:09 PM, Gerd Hoffmann wrote: > > + PageTables = 0; > > + if (FeaturePcdGet (PcdDxeIplBuildPageTables)) { > > Can this ever be false in a x64 build? You're right. This cannot be false in X64 build. I will refactor it in the next version. > > > +EFI_STATUS > > +FindDxeCore

Re: [edk2-devel] [PATCH 06/10] OvmfPkg: Add TdxStartupLib

2021-12-15 Thread Gerd Hoffmann
Hi, > + PageTables = 0; > + if (FeaturePcdGet (PcdDxeIplBuildPageTables)) { Can this ever be false in a x64 build? > +EFI_STATUS > +FindDxeCore ( > + IN INTN FvInstance, > + IN OUT EFI_PEI_FILE_HANDLE *FileHandle > + ) > +{ > + if (FvInstance != -1) { > +

[edk2-devel] [PATCH 06/10] OvmfPkg: Add TdxStartupLib

2021-12-14 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 TdxStarupLib provides a function (TdxStartup ()) which brings up the Tdx guest from SEC phase to DXE phase. PEI phase is skipped because most of the components in PEI phase is not needed for Tdx guest, for example, MP Services, TPM etc. In t