On September 11, 2021 9:15 AM, Erden Aktas wrote:
> On Thu, Aug 12, 2021 at 2:57 PM Min Xu wrote:
> > +
> > +#include
> > +#include "InternalTdxProbe.h"
> > +
> > +/**
> > + TDX only works in X64. So allways return -1 to indicate Non-Td.
> s/allways/always
>
> Also, -1 or 1? PROBE_NOT_TD_GUEST
On Thu, Aug 12, 2021 at 2:57 PM Min Xu wrote:
> +
> +#include
> +#include "InternalTdxProbe.h"
> +
> +/**
> + TDX only works in X64. So allways return -1 to indicate Non-Td.
s/allways/always
Also, -1 or 1? PROBE_NOT_TD_GUEST is defined as 1.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receiv
Hi,
> > Also: Why there are separate TdxProbeLib + TdxLib libs?
> This is because TdxLib wrap the operations of TdCall and TdVmcall. While
> TdxProbeLib
> is a library to probe (call CPUID(0x21)) if it is td guest or not. I am open
> to merge these 2
> libs into one if the community think it i
On August 17, 2021 4:21 PM, Gerd Hoffmann wrote:
> On Tue, Aug 17, 2021 at 12:14:44AM +, Min Xu wrote:
> > On Monday, August 16, 2021 5:43 PM, Gerd Hoffmann wrote:
> > > > +++ b/MdePkg/Library/TdxProbeLib/X64/TdProbe.nasm
> > >
> > > Any specific reason why you code up your own instead of using
On Tue, Aug 17, 2021 at 12:14:44AM +, Min Xu wrote:
> On Monday, August 16, 2021 5:43 PM, Gerd Hoffmann wrote:
> > > +++ b/MdePkg/Library/TdxProbeLib/X64/TdProbe.nasm
> >
> > Any specific reason why you code up your own instead of using the existing
> > cpuid functions in BaseLib ?
> Actually
On Monday, August 16, 2021 5:43 PM, Gerd Hoffmann wrote:
> > +++ b/MdePkg/Library/TdxProbeLib/X64/TdProbe.nasm
>
> Any specific reason why you code up your own instead of using the existing
> cpuid functions in BaseLib ?
Actually there is no specific reason. I am not sure if AsmCpuid is a preferre
> +++ b/MdePkg/Library/TdxProbeLib/X64/TdProbe.nasm
Any specific reason why you code up your own instead of using the
existing cpuid functions in BaseLib ?
take care,
Gerd
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#79347): https:
RFC： https://bugzilla.tianocore.org/show_bug.cgi?id=3429
Guest software can be designed to run either as a TD, as a legacy virtual
machine, or directly on the CPU, based on enumeration of its run-time
environment. CPUID leaf 0x21 emulation is done by the Intel TDX module.
Sub-leaf 0 returns the va
