Re: [edk2-devel] [PATCH 0/3] Arm builds on Visual Studio

2019-09-23 Thread Liming Gao
inney, Michael D ; Zhang, Shenglei > >Subject: Re: [edk2-devel] [PATCH 0/3] Arm builds on Visual Studio > >On Thu, Sep 19, 2019 at 09:24:15PM +0200, Laszlo Ersek wrote: >> On 09/19/19 11:44, Leif Lindholm wrote: >> > I agree with this as a general rule, but for this (hopef

Re: [edk2-devel] [PATCH 0/3] Arm builds on Visual Studio

2019-09-19 Thread Leif Lindholm
On Thu, Sep 19, 2019 at 09:24:15PM +0200, Laszlo Ersek wrote: > On 09/19/19 11:44, Leif Lindholm wrote: > > I agree with this as a general rule, but for this (hopefully never to > > be repeated) operation, it makes sense to me to keep each change in > > this set as one patch. > > > > For the simpl

Re: [edk2-devel] [PATCH 0/3] Arm builds on Visual Studio

2019-09-19 Thread Andrew Fish via Groups.Io
> On Sep 19, 2019, at 12:24 PM, Laszlo Ersek wrote: > > On 09/19/19 11:44, Leif Lindholm wrote: >> Hi Liming, >> >> On Thu, Sep 19, 2019 at 06:19:42AM +, Gao, Liming wrote: >>> I add my comments. >>> -Original Message- From: Baptiste Gerondeau [mailto:baptiste.gerond...

Re: [edk2-devel] [PATCH 0/3] Arm builds on Visual Studio

2019-09-19 Thread Laszlo Ersek
On 09/19/19 11:44, Leif Lindholm wrote: > Hi Liming, > > On Thu, Sep 19, 2019 at 06:19:42AM +, Gao, Liming wrote: >> I add my comments. >> >>> -Original Message- >>> From: Baptiste Gerondeau [mailto:baptiste.gerond...@linaro.org] >>> Sent: Thursday, September 19, 2019 12:05 AM >>> To:

Re: [edk2-devel] [PATCH 0/3] Arm builds on Visual Studio

2019-09-19 Thread Liming Gao
Leif: For this special case of the single patch to include the changes in cross packages, I include Laszlo, Fish and Mike for the discussion. Thanks Liming > -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Thursday, September 19, 2019 5:45 PM > To: Ga

Re: [edk2-devel] [PATCH 0/3] Arm builds on Visual Studio

2019-09-19 Thread Leif Lindholm
Hi Liming, On Thu, Sep 19, 2019 at 06:19:42AM +, Gao, Liming wrote: > I add my comments. > > >-Original Message- > >From: Baptiste Gerondeau [mailto:baptiste.gerond...@linaro.org] > >Sent: Thursday, September 19, 2019 12:05 AM > >To: devel@edk2.groups.io > >Cc: ard.biesheu...@linaro.

Re: [edk2-devel] [PATCH 0/3] Arm builds on Visual Studio

2019-09-18 Thread Liming Gao
I add my comments. >-Original Message- >From: Baptiste Gerondeau [mailto:baptiste.gerond...@linaro.org] >Sent: Thursday, September 19, 2019 12:05 AM >To: devel@edk2.groups.io >Cc: ard.biesheu...@linaro.org; leif.lindh...@linaro.org; Kinney, Michael D >; Gao, Liming ; Zhang, >Shenglei ; Ba

Re: [edk2-devel] [PATCH 0/3] Arm builds on Visual Studio

2019-09-18 Thread Leif Lindholm
Thanks Baptiste, Ard: I would appreciate if you could sanity check the syntax conversion in 2/3 - it looks correct to me. >From my point of view, for the series: Reviewed-by: Leif Lindholm But we also need a nod from the MdePkg maintainers. / Leif On Wed, Sep 18, 2019 at 06:05:21PM +0200,

[edk2-devel] [PATCH 0/3] Arm builds on Visual Studio

2019-09-18 Thread Baptiste Gerondeau
We are currently making an effort to make ARM (and AARCH64 eventually) builds using Microsoft's Visual Studio Compiler (aka MSVC/MSFT). These 3 patches correspond to an effort to make the assembler work with MSFT, which entails : - Feeding MSFT the RVCT .asm files, since they share syntax requir