Leif: For this special case of the single patch to include the changes in cross packages, I include Laszlo, Fish and Mike for the discussion.
Thanks Liming > -----Original Message----- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Thursday, September 19, 2019 5:45 PM > To: Gao, Liming <liming....@intel.com> > Cc: Baptiste Gerondeau <baptiste.gerond...@linaro.org>; devel@edk2.groups.io; > ard.biesheu...@linaro.org; Kinney, Michael D > <michael.d.kin...@intel.com>; Zhang, Shenglei <shenglei.zh...@intel.com> > Subject: Re: [PATCH 0/3] Arm builds on Visual Studio > > Hi Liming, > > On Thu, Sep 19, 2019 at 06:19:42AM +0000, Gao, Liming wrote: > > I add my comments. > > > > >-----Original Message----- > > >From: Baptiste Gerondeau [mailto:baptiste.gerond...@linaro.org] > > >Sent: Thursday, September 19, 2019 12:05 AM > > >To: devel@edk2.groups.io > > >Cc: ard.biesheu...@linaro.org; leif.lindh...@linaro.org; Kinney, Michael D > > ><michael.d.kin...@intel.com>; Gao, Liming <liming....@intel.com>; Zhang, > > >Shenglei <shenglei.zh...@intel.com>; Baptiste Gerondeau > > ><baptiste.gerond...@linaro.org> > > >Subject: [PATCH 0/3] Arm builds on Visual Studio > > > > > >EDIT: Resending the series since I mistakenly used the wrong email, > > >sorry ! > > > > > >We are currently making an effort to make ARM (and AARCH64 eventually) > > >builds using Microsoft's Visual Studio Compiler (aka MSVC/MSFT). > > > > > >These 3 patches correspond to an effort to make the assembler work with > > >MSFT, which entails : > > >- Feeding MSFT the RVCT .asm files, since they share syntax > > > requirements. > > > > Please separate the patch. Each patch is for each package, can't cross > > packages. > > If so, the package maintainer can easy review the change. > > I agree with this as a general rule, but for this (hopefully never to > be repeated) operation, it makes sense to me to keep each change in > this set as one patch. > > For the simple reason that the alternative leaves several unusable > commits in sequence in the repository. There is simply no way to > bisect through this change on a per-package basis. > > This is after all a horrible horrible hack that lets us keep using the > .asm files provided for one toolchain family (RVCT) in a different > toolchain family (MSFT), without having to delete and re-add, losing > history in the process. > > Would you be OK with an exception for this extremely unusual > situation? > > > >- Fixing some instructions syntax in those .asm files, in order to make > > > them palatable for MSFT. > > >- Fixing some minor formatting issue in INF files, while we're at it. > > > > > >This set enables the assembler, meanwhile the C also require changes, > > >which will come in a set later. This set makes the RVCT toolchain family > > >and profiles obsolete, unblocking : > > >BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1750 > > > > With this change, can we continue to work on BZ 1750? > > Yes. > > / > Leif > > > >As mentioned in the above bug, dropping RVCT would entail orphanating > > >the .asm files that powered the RVCT build. Since Visual Studio uses the > > >same file syntax, those can be reused to power the VS build. > > > > > >These patches have been tested on VS2019 (v15.9.11) and VS2017 (v16.0.1) > > > > Do you mean you verify this change with new VS2019 tool chain? > > > > Thanks > > Liming > > > > > >Baptiste GERONDEAU (3): > > > ArmPkg/MdePkg : Unify INF files format > > > ARM/Assembler: Correct syntax from RVCT for MSFT > > > ARM/Assembler: Reuse RVCT assembler for MSFT build > > > > > > ArmPkg/Drivers/ArmGic/ArmGicLib.inf | 2 > > > +- > > > ArmPkg/Library/ArmExceptionLib/Arm/ExceptionSupport.asm | 30 > > >+++++++++++++++++------------- > > > ArmPkg/Library/ArmExceptionLib/ArmExceptionLib.inf | 2 > > > +- > > > ArmPkg/Library/ArmExceptionLib/ArmRelocateExceptionLib.inf | 2 > > > +- > > > ArmPkg/Library/ArmHvcLib/ArmHvcLib.inf | 2 > > > +- > > > ArmPkg/Library/ArmLib/Arm/ArmV7Support.asm | 6 > > > ++++-- > > > ArmPkg/Library/ArmLib/ArmBaseLib.inf | 8 > > > ++++---- > > > ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf | 4 > > > ++-- > > > ArmPkg/Library/ArmSmcLib/ArmSmcLib.inf | 2 > > > +- > > > ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf > > >| 2 +- > > > ArmPkg/Library/ArmSvcLib/ArmSvcLib.inf | 2 > > > +- > > > ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformLibNull.inf | 2 > > > +- > > > ArmPlatformPkg/Library/ArmPlatformStackLib/ArmPlatformStackLib.inf | 2 > > >+- > > > ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf | 6 > > > +++--- > > > ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf | 6 > > > +++--- > > > ArmPlatformPkg/PrePi/PeiMPCore.inf | 2 > > > +- > > > ArmPlatformPkg/PrePi/PeiUniCore.inf | 2 > > > +- > > > MdePkg/Library/BaseIoLibIntrinsic/Arm/ArmVirtMmio.asm | 18 > > >+++++++++--------- > > > MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsicArmVirt.inf | 2 > > > +- > > > MdePkg/Library/BaseMemoryLibOptDxe/BaseMemoryLibOptDxe.inf | > > >20 ++++++++++---------- > > > MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf | 2 > > > +- > > > 21 files changed, 65 insertions(+), 59 deletions(-) > > > > > >-- > > >2.23.0 > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#47602): https://edk2.groups.io/g/devel/message/47602 Mute This Topic: https://groups.io/mt/34187297/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
