Re: [edk2-devel] [PATCH 0/2] IntelFsp2Pkg: Coverity scan flags issues

2020-02-11 Thread Nate DeSimone
For the patch series... Reviewed-by: Nate DeSimone -Original Message- From: Chiu, Chasel Sent: Sunday, February 9, 2020 7:53 PM To: devel@edk2.groups.io Cc: Ma, Maurice ; Desimone, Nathaniel L ; Zeng, Star Subject: [PATCH 0/2] IntelFsp2Pkg: Coverity scan flags issues GenCfgOpt.py: I

Re: [edk2-devel] [PATCH 0/2] IntelFsp2Pkg: Coverity scan flags issues

2020-02-09 Thread Zeng, Star
Reviewed-by: Star Zeng > -Original Message- > From: Chiu, Chasel > Sent: Monday, February 10, 2020 11:53 AM > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [PATCH 0/2] IntelFsp2Pkg: Coverity scan flags issues > > GenCfgOpt.py: > Issue was:

[edk2-devel] [PATCH 0/2] IntelFsp2Pkg: Coverity scan flags issues

2020-02-09 Thread Chiu, Chasel
GenCfgOpt.py: Issue was: invalid_operation: Invalid operation on null-like value "Base". Fixed it by initializing Base to 0 before entering while loop. SplitFspBin.py: Issues were: 1. copy_paste_error: PeOptHdr vs PePlusOptHdr. 2. invalid_operation: Invalid operation on null-like value "roffset".