tcheretianski, Andrei
>
> Subject: Re: [edk2-devel] [PATCH] NetworkPkg: Add WiFi profile sync protocol
> support
>
> One comment as below, Others good to me.
>
> Reviewed-by: Wu Jiaxin
>
>
> > + @param[in, out] WcmProfile WiFi Connection Manager profile
>
One comment as below, Others good to me.
Reviewed-by: Wu Jiaxin
> + @param[in, out] WcmProfile WiFi Connection Manager profile
> structure
> + @param[in, out] MacAddress MAC address from AMT saved to NiC
> MAC address
> +
> + @retval EFI_SUCCESS Stored WiFi profi
Hey Jiaxin,
Please rind my updated patch below. Let me know when you get this reviewed so I
can get it merged as soon as possible.
Thank you,
Zack
-Original Message-
From: Clark-williams, Zachary
Sent: Friday, January 6, 2023 5:31 PM
To: devel@edk2.groups.io
Cc: Zachary Clark-William
From: Zachary Clark-Williams
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3845
Enables KVM and One Click Recovery WLAN capability with WiFi Profile
Sync feature and protocol. Adding WiFiProfileSyncProtocol, which
supports the profilesync driver operations for transferring WiFi profiles
fr
Thank you Jiaxin,
Find my responses inline.
An updated patch with requested changes is in route today.
Thanks,
Zack
-Original Message-
From: Wu, Jiaxin
Sent: Thursday, January 5, 2023 9:09 PM
To: Clark-williams, Zachary ;
devel@edk2.groups.io; Kinney, Michael D
Cc: Zachary C
Hi Zachary,
Insert all my comments as below.
Besides: where defined this protocol (EFI_WIFI_PROFILE_SYNC_PROTOCOL)? I didn't
find in the UEFI spec, in such a case, could we named it as
EDKII_WIFI_PROFILE_SYNC_PROTOCOL? please add more description about the
protocol usage.
Thanks,
Jiaxin
> +
From: Zachary Clark-Williams
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3845
Enables KVM and One Click Recovery WLAN capability with WiFi Profile
Sync feature and protocol. Adding WiFiProfileSyncProtocol, which
supports the profilesync driver operations for transferring WiFi profiles
fr
Cc: Zachary Clark-Williams ; Maciej Rabeda
Subject: Re: [edk2-devel] [PATCH] NetworkPkg: Add WiFi profile sync protocol
support
On 26/09/2022 16:39, Clark-williams, Zachary wrote:
>>> + if (Profile->Password[StrLen (Profile->Password)] != '\0') {
>>> +
On 26/09/2022 16:39, Clark-williams, Zachary wrote:
+ if (Profile->Password[StrLen (Profile->Password)] != '\0') {
+Profile->Password[StrLen (Profile->Password)] = L'\0'; }
+
I don't understand this change, StrLen returns the length of a Null-terminated Unicode string,
it means "Profile->
37 AM
To: devel@edk2.groups.io; Clark-williams, Zachary
Cc: Zachary Clark-Williams ; Maciej Rabeda
Subject: RE: [edk2-devel] [PATCH] NetworkPkg: Add WiFi profile sync protocol
support
Hi Zachary,
> @@ -420,22 +422,34 @@ WifiMgrConfigPassword (
>//
>// Set password
roups.io On Behalf Of Clark-
> williams, Zachary
> Sent: Thursday, September 15, 2022 3:43 AM
> To: devel@edk2.groups.io
> Cc: Zachary Clark-Williams ; Clark-williams, Zachary
>
> Subject: [edk2-devel] [PATCH] NetworkPkg: Add WiFi profile sync protocol
> support
>
> From:
From: Zachary Clark-Williams
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3845
Enables KVM and One Click Recovery WLAN capability with WiFi Profile
Sync feature and protocol. Adding WiFiProfileSyncProtocol, which
supports the profilesync driver operations for transferring WiFi profiles
fr
12 matches
Mail list logo
