Re: [edk2-devel] [PATCH] EmbeddedPkg/RealTimeClockRuntimeDxe: Improve GetWakeupTime

2021-06-02 Thread Ard Biesheuvel
On Mon, 24 May 2021 at 05:55, Marcin Wojtas wrote: > > GetWakeupTime should return full time information, including > the daylight/timezone. Make use of the existing non-volatile > variables for that purpose. Moreover add an error checking > of possibly invalid parameters. > This partially fixes F

Re: [edk2-devel] [PATCH] EmbeddedPkg/RealTimeClockRuntimeDxe: Improve GetWakeupTime

2021-05-23 Thread Sunny Wang
Looks good to me. Good catch! Reviewed-by: Sunny Wang By the way, just FYI, I still run into the same problem (line-ending problem) with Windows Outlook and EDK2 email archive https://edk2.groups.io/g/devel/topic/patch/83043513?p=,,,20,0,0,0::recentpostdate%2Fsticky,,,20,2,0,83043513. Moreover

[edk2-devel] [PATCH] EmbeddedPkg/RealTimeClockRuntimeDxe: Improve GetWakeupTime

2021-05-23 Thread Marcin Wojtas
GetWakeupTime should return full time information, including the daylight/timezone. Make use of the existing non-volatile variables for that purpose. Moreover add an error checking of possibly invalid parameters. This partially fixes FWTS and SCT Set/GetWakeupTime tests on Marvell platforms. Signe