Re: [edk2-devel] [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid

2023-03-28 Thread Jianyong Wu
Hi Sami, Inline replay. > -Original Message- > From: Sami Mujawar > Sent: 2023年3月28日 16:34 > To: Jianyong Wu > Cc: devel@edk2.groups.io; Ard Biesheuvel ; > suni...@ventanamicro.com > Subject: Re: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid > > Hi Jianyong, > > Please find my

Re: [edk2-devel] [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid

2023-03-28 Thread Sami Mujawar
Hi Jianyong, Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 28/03/2023, 09:17, "Jianyong Wu" mailto:jianyong...@arm.com>> wrote: Hi Sami, I have never added CI for CloudHv. So, should I add it? [SAMI] I think you can prepare the patch that adds the CI support and pu

Re: [edk2-devel] [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid

2023-03-28 Thread Jianyong Wu
Hi Sami, I have never added CI for CloudHv. So, should I add it? Also, I will update this patch based on your comment and send the second version. Thanks, Jianyong > -Original Message- > From: Sami Mujawar > Sent: 2023年3月28日 15:52 > To: Sunil V L ; Jianyong Wu > > Cc: devel@edk2.grou

Re: [edk2-devel] [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid

2023-03-28 Thread Sami Mujawar
Hi Jianyong, Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 28/03/2023, 08:45, "Sunil V L" mailto:suni...@ventanamicro.com>> wrote: On Tue, Mar 28, 2023 at 03:28:25AM +, Jianyong Wu wrote: > Add Ard Biesheuvel mailto:a...@kernel.org>> and Sunil V L > mailto:suni.

Re: [edk2-devel] [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid

2023-03-28 Thread Sami Mujawar
Hi Jianyong, Thank you for this fix. The subject line should have the package name as prefix followed by the short description for the patch e.g. "ArmVirtPkg: xxx". Other than that, this change looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 28/03/2023, 04:28, "Jianyon

Re: [edk2-devel] [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid

2023-03-27 Thread Sunil V L
On Tue, Mar 28, 2023 at 03:28:25AM +, Jianyong Wu wrote: > Add Ard Biesheuvel and Sunil V L > to cc list. > > > -Original Message- > > From: Jianyong Wu > > Sent: 2023年2月17日 14:48 > > To: devel@edk2.groups.io; Sami Mujawar > > Cc: Jianyong Wu > > Subject: [PATCH] CloudHv: can't f

Re: [edk2-devel] [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid

2023-03-27 Thread Sunil V L
On Tue, Mar 28, 2023 at 03:28:25AM +, Jianyong Wu wrote: > Add Ard Biesheuvel and Sunil V L > to cc list. > > > -Original Message- > > From: Jianyong Wu > > Sent: 2023年2月17日 14:48 > > To: devel@edk2.groups.io; Sami Mujawar > > Cc: Jianyong Wu > > Subject: [PATCH] CloudHv: can't f

Re: [edk2-devel] [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid

2023-03-27 Thread Jianyong Wu
Add Ard Biesheuvel and Sunil V L to cc list. > -Original Message- > From: Jianyong Wu > Sent: 2023年2月17日 14:48 > To: devel@edk2.groups.io; Sami Mujawar > Cc: Jianyong Wu > Subject: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid > > commit f13264b34 introduces a bug for CloudH

[edk2-devel] [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid

2023-02-16 Thread Jianyong Wu
commit f13264b34 introduces a bug for CloudHv as OvmfPkg/OvmfPkg.dec is missing in CloudHvHasAcpiDtDxe.inf which leads to gUefiOvmfPkgTokenSpaceGuid found nowhere. Signed-off-by: Jianyong Wu --- ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf | 1 + 1 file changed, 1 insertion(+)