Re: [edk2-devel] [PATCH] ArmPlatformPkg/PL011UartLib: Add PCD for FIFO depth

2020-06-08 Thread Ard Biesheuvel
On 6/8/20 4:47 PM, Irene Park via Groups.Io wrote: Hi Ard, I feel bad that I confused you. I'll update the commit message later. SBSA spec doesn't "mandate" that the optional registers such as PID2 are present in a UART compliant to PL011. Therefore this register access to PID2 will generate a f

Re: [edk2-devel] [PATCH] ArmPlatformPkg/PL011UartLib: Add PCD for FIFO depth

2020-06-08 Thread Irene Park
Hi Ard, I feel bad that I confused you. I'll update the commit message later. SBSA spec doesn't "mandate" that the optional registers such as PID2 are present in a UART compliant to PL011. Therefore this register access to PID2 will generate a fault onto SOC when its UART doesn't provide such reg

Re: [edk2-devel] [PATCH] ArmPlatformPkg/PL011UartLib: Add PCD for FIFO depth

2020-06-08 Thread Ard Biesheuvel
On 6/6/20 5:23 AM, Irene Park via groups.io wrote: From: Irene Park PL011UartLib determines its FIFO depth based on the PID2 value but the register PID2 is not mandatory in the SBSA spec. This change adds a new 32bit PCD reference to define a FIFO depth and make PL011UartLib available for the c

Re: [edk2-devel] [PATCH] ArmPlatformPkg/PL011UartLib: Add PCD for FIFO depth

2020-06-07 Thread Irene Park
Hello Ard Biesheuvel, Would you please review this change? Thank you, Irene -Original Message- From: Irene Park Sent: Friday, June 5, 2020 11:23 PM To: devel@edk2.groups.io Cc: Irene Park Subject: [PATCH] ArmPlatformPkg/PL011UartLib: Add PCD for FIFO depth From: Irene Park PL011UartLi

Re: [edk2-devel] [PATCH] ArmPlatformPkg/PL011UartLib: Add PCD for FIFO depth

2020-06-05 Thread Irene Park
Hello Ard Biesheuvel, Would you please review this change? Thank you, Irene -Original Message- From: Irene Park Sent: Friday, June 5, 2020 11:23 PM To: devel@edk2.groups.io Cc: Irene Park Subject: [PATCH] ArmPlatformPkg/PL011UartLib: Add PCD for FIFO depth From: Irene Park PL011UartL

[edk2-devel] [PATCH] ArmPlatformPkg/PL011UartLib: Add PCD for FIFO depth

2020-06-05 Thread Irene Park
From: Irene Park PL011UartLib determines its FIFO depth based on the PID2 value but the register PID2 is not mandatory in the SBSA spec. This change adds a new 32bit PCD reference to define a FIFO depth and make PL011UartLib available for the custom UART which is compliant to the SBSA spec but do