Re: [edk2-devel] [[PATCH 1/1]] EmulatorPkg using CpuBreakPoint

2019-11-15 Thread Kilian Kegel
ups.io>; Gao, Liming<mailto:liming....@intel.com> Cc: Richardson, Brian<mailto:brian.richard...@intel.com>; Kinney, Michael D<mailto:michael.d.kin...@intel.com> Subject: RE: [edk2-devel] [[PATCH 1/1]] EmulatorPkg using CpuBreakPoint Kilian, Thank you very much. Comments below. From:

Re: [edk2-devel] [[PATCH 1/1]] EmulatorPkg using CpuBreakPoint

2019-11-13 Thread Ni, Ray
Kilian, Thank you very much. Comments below. From: Kilian Kegel Sent: Thursday, November 14, 2019 1:24 PM To: Ni, Ray ; devel@edk2.groups.io; Gao, Liming Cc: Richardson, Brian ; Kinney, Michael D Subject: RE: [edk2-devel] [[PATCH 1/1]] EmulatorPkg using CpuBreakPoint I have no preference

Re: [edk2-devel] [[PATCH 1/1]] EmulatorPkg using CpuBreakPoint

2019-11-13 Thread Kilian Kegel
ilto:liming@intel.com>; kilian_ke...@outlook.com<mailto:kilian_ke...@outlook.com> Cc: Richardson, Brian<mailto:brian.richard...@intel.com>; Kinney, Michael D<mailto:michael.d.kin...@intel.com> Subject: RE: [edk2-devel] [[PATCH 1/1]] EmulatorPkg using CpuBreakPoint Kilian, T

Re: [edk2-devel] [[PATCH 1/1]] EmulatorPkg using CpuBreakPoint

2019-11-12 Thread Ni, Ray
, Liming Subject: Re: [edk2-devel] [[PATCH 1/1]] EmulatorPkg using CpuBreakPoint Kilian: Can you create the patch with the commit message? For the patch, I add my comments. From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> [mailto:devel@edk2.groups.io] On Behalf Of Kilian Kege

Re: [edk2-devel] [[PATCH 1/1]] EmulatorPkg using CpuBreakPoint

2019-11-12 Thread Liming Gao
, Michael D Subject: [edk2-devel] [[PATCH 1/1]] EmulatorPkg using CpuBreakPoint Hi Liming, >Kilian: can you send the patch to edk2 mail list for code review? Regards, Kilian https://bugzilla.tianocore.org/show_bug.cgi?id=2319 diff --git a/EmulatorPkg/Win/Host/WinHost.c b/EmulatorPkg/Win/H

[edk2-devel] [[PATCH 1/1]] EmulatorPkg using CpuBreakPoint

2019-11-05 Thread Kilian Kegel
Hi Liming, >Kilian: can you send the patch to edk2 mail list for code review? Regards, Kilian https://bugzilla.tianocore.org/show_bug.cgi?id=2319 diff --git a/EmulatorPkg/Win/Host/WinHost.c b/EmulatorPkg/Win/Host/WinHost.c index 62a89f7617..53cda86f9a 100644 --- a/EmulatorPkg/Win/Host/WinHost.c +