Hi Liming, >Kilian: can you send the patch to edk2 mail list for code review? Regards, Kilian
https://bugzilla.tianocore.org/show_bug.cgi?id=2319 diff --git a/EmulatorPkg/Win/Host/WinHost.c b/EmulatorPkg/Win/Host/WinHost.c index 62a89f7617..53cda86f9a 100644 --- a/EmulatorPkg/Win/Host/WinHost.c +++ b/EmulatorPkg/Win/Host/WinHost.c @@ -409,7 +409,30 @@ Returns: FirmwareVolumesStr = (CHAR16 *) PcdGetPtr (PcdEmuFirmwareVolume); SecPrint ("\n\rEDK II WIN Host Emulation Environment from http://www.tianocore.org/edk2/\n\r";); - + + if (1) { + int i; + SecPrint ("######################################################################################################\n"); + SecPrint ("add \"/debug\" command line switch, to connect to the debugger at the very beginning of POST emulation\n"); + SecPrint ("######################################################################################################\n"); + if (Argc > 1) { + for (i = 1; i < Argc; i++) { + if (0 == strcmp("/debug", Argv[i])) { + //SecPrint("IF YOU WANT TO DEBUG from the very beginning of the EMULATION:\n\t1. start the TASKMGR\n\t2. connect WinHost.exe to the debugger\n\t3. and press ENTER in this command box\nOR\n"); + SecPrint("\t1. start your debug engine\n"); + SecPrint("\t2. attache to process WinHost.exe\n"); + SecPrint("\t4. SET A SOFTWARE BREAKPOINT (F9) in line 431\n"); + SecPrint("\t5. and press ENTER in the WinHost command box\n"); + SecPrint("\t6. go back to the debug engine and RUN/SINGLE STEP the application\n"); + SecPrint("\t7. otherwise press enter to continue...\n"); + + getchar(); //wait for keyboard input + + SecPrint("");//now you can single step the entire boot/emulation process, good luck... + } + } + } + } // // Determine the first thread available to this process. // ________________________________ From: Kilian Kegel <kilian_ke...@outlook.com> Sent: Monday, October 28, 2019 2:01:23 PM To: liming....@intel.com <liming....@intel.com> Cc: devel@edk2.groups.io <devel@edk2.groups.io>; Richardson, Brian <brian.richard...@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com> Subject: [edk2-devel] [edk2] [EmulatorPkg] using __debugbreak() Hi Liming, If have observed in newer Windows 10 versions, when using __debugbreak()in any application that Windows just terminates the app, instead offering to debug it. So in WinHost.exe too. That’s why I usually insert the code snippet below to run into getchar() when the program was started with the /debug command line switch. As long as the App waits for the next keystroke, I can start the debugger (VS2019) and connect to WinHost.exe process for debugging. Do you have a better solution without modifying the source code? Thanks, Kilian if(1){ int i; SecPrint ("######################################################################################################\n"); SecPrint ("add \"/debug\" command line switch, to connect to the debugger at the very beginning of POST emulation\n"); SecPrint ("######################################################################################################\n"); if(Argc > 1){ for(i = 1 ; i < Argc ; i++){ if(0 == strcmp("/debug", Argv[i])){ //SecPrint("IF YOU WANT TO DEBUG from the very beginning of the EMULATION:\n\t1. start the TASKMGR\n\t2. connect WinHost.exe to the debugger\n\t3. and press ENTER in this command box\nOR\n"); SecPrint("\t1. start Visual Studio\n"); SecPrint("\t2. DEBUG->ATTACH TO PROCESS (CTRL + ALT + P) --> WinHost.exe\n"); SecPrint("\t3. Break All (CTRL + ALT + Break) --> WinHost.exe\n"); SecPrint("\t4. SET A SOFTWARE BREAKPOINT (F9) in line 445\n"); SecPrint("\t5. and press ENTER in this command box\n"); SecPrint("\t6. go back to Visual Studio an RUN/SINGLE STEP the application\n"); SecPrint("\t7. otherwise press enter to continue...\n"); getchar(); // // 1. SET A SOFTWARE BREAKPOINT TO THE NEXT LINE of code below -->> SecPrint(""); // 2. switch to the command box and press ENTER // 3. start single stepping the entire boot/emulation process, good luck... // SecPrint("");//now you can single step the entire boot/emulation process, good luck... } } } } -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#49972): https://edk2.groups.io/g/devel/message/49972 Mute This Topic: https://groups.io/mt/42294764/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
