Re: [edk2-devel][Patch v2 7/7] MdeModulePkg: Add Capsule On Disk APIs into CapsuleLib.

2019-06-19 Thread Xu, Wei6
ge- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > Wu, Hao A > > Sent: Wednesday, June 19, 2019 4:17 PM > > To: Xu, Wei6; devel@edk2.groups.io > > Cc: Wang, Jian J; Zhang, Chao B > > Subject: Re: [edk2-devel][Patch v2 7/7] MdeModulePkg:

Re: [edk2-devel][Patch v2 7/7] MdeModulePkg: Add Capsule On Disk APIs into CapsuleLib.

2019-06-19 Thread Wu, Hao A
PM > To: Xu, Wei6; devel@edk2.groups.io > Cc: Wang, Jian J; Zhang, Chao B > Subject: Re: [edk2-devel][Patch v2 7/7] MdeModulePkg: Add Capsule On > Disk APIs into CapsuleLib. > > > > > No, that's how it is designed. > > PcdCodRelocationDevPath is used by

Re: [edk2-devel][Patch v2 7/7] MdeModulePkg: Add Capsule On Disk APIs into CapsuleLib.

2019-06-19 Thread Wu, Hao A
> > No, that's how it is designed. > PcdCodRelocationDevPath is used by platform to specify a device to store > temp Cod relocation file. > If this PCD is not available, it means that platform doesn't have a > requirement > to store the file to a specific place. > Then save the file to the devic

Re: [edk2-devel][Patch v2 7/7] MdeModulePkg: Add Capsule On Disk APIs into CapsuleLib.

2019-06-19 Thread Xu, Wei6
; Cc: Wang, Jian J; Wu, Hao A; Zhang, Chao B; Xu, Wei6 > > Subject: [edk2-devel][Patch v2 7/7] MdeModulePkg: Add Capsule On Disk > > APIs into CapsuleLib. > > > Not directly related with this patch, I saw many function declarations > within .C file for this library. Could you he

Re: [edk2-devel][Patch v2 7/7] MdeModulePkg: Add Capsule On Disk APIs into CapsuleLib.

2019-06-12 Thread Wu, Hao A
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Xu, > Wei6 > Sent: Wednesday, June 05, 2019 11:42 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J; Wu, Hao A; Zhang, Chao B; Xu, Wei6 > Subject: [edk2-devel][Patch v2 7

[edk2-devel][Patch v2 7/7] MdeModulePkg: Add Capsule On Disk APIs into CapsuleLib.

2019-06-05 Thread Xu, Wei6
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1852 CoDCheckCapsuleOnDiskFlag() is to check if CapsuleOnDisk flag in "OsIndications" Variable is enabled. It is used to indicate whether capsule on disk is provisioned in normal boot path. CoDClearCapsuleOnDiskFlag() is to to clear CapsuleOnDisk